Skip to content

Commit

Permalink
Show formatted number in the error indicator painter
Browse files Browse the repository at this point in the history
  • Loading branch information
imaNNeo committed Jan 10, 2025
1 parent 867d89b commit 5a0fbfe
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 5 deletions.
27 changes: 23 additions & 4 deletions lib/src/chart/base/axis_chart/axis_chart_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import 'package:equatable/equatable.dart';
import 'package:fl_chart/fl_chart.dart';
import 'package:fl_chart/src/chart/base/axis_chart/axis_chart_painter.dart';
import 'package:fl_chart/src/utils/lerp.dart';
import 'package:fl_chart/src/utils/utils.dart';
import 'package:flutter/material.dart' hide Image;

/// This is the base class for axis base charts data
Expand Down Expand Up @@ -1731,6 +1732,7 @@ abstract class FlSpotErrorRangePainter with EquatableMixin {
Offset offsetInCanvas,
FlSpot origin,
Rect errorRelativeRect,
AxisChartData axisChartData,
);
}

Expand Down Expand Up @@ -1773,6 +1775,7 @@ class FlSimpleErrorPainter extends FlSpotErrorRangePainter with EquatableMixin {
Offset offsetInCanvas,
FlSpot origin,
Rect errorRelativeRect,
AxisChartData axisChartData,
) {
final rect = errorRelativeRect.shift(offsetInCanvas);
final hasVerticalError = errorRelativeRect.height != 0;
Expand All @@ -1790,7 +1793,11 @@ class FlSimpleErrorPainter extends FlSpotErrorRangePainter with EquatableMixin {
rect: rect,
isHorizontal: false,
isLower: true,
text: (origin.y - origin.yError!.lowerBy).toString(),
text: Utils().formatNumber(
axisChartData.minY,
axisChartData.maxY,
origin.y - origin.yError!.lowerBy,
),
textStyle: errorTextStyle,
);

Expand All @@ -1800,7 +1807,11 @@ class FlSimpleErrorPainter extends FlSpotErrorRangePainter with EquatableMixin {
rect: rect,
isHorizontal: false,
isLower: false,
text: (origin.y + origin.yError!.upperBy).toString(),
text: Utils().formatNumber(
axisChartData.minY,
axisChartData.maxY,
origin.y + origin.yError!.upperBy,
),
textStyle: errorTextStyle,
);
}
Expand All @@ -1821,7 +1832,11 @@ class FlSimpleErrorPainter extends FlSpotErrorRangePainter with EquatableMixin {
rect: rect,
isHorizontal: true,
isLower: true,
text: (origin.x - origin.xError!.lowerBy).toString(),
text: Utils().formatNumber(
axisChartData.minX,
axisChartData.maxX,
origin.x - origin.xError!.lowerBy,
),
textStyle: errorTextStyle,
);

Expand All @@ -1831,7 +1846,11 @@ class FlSimpleErrorPainter extends FlSpotErrorRangePainter with EquatableMixin {
rect: rect,
isHorizontal: true,
isLower: false,
text: (origin.x + origin.xError!.upperBy).toString(),
text: Utils().formatNumber(
axisChartData.minX,
axisChartData.maxX,
origin.x + origin.xError!.upperBy,
),
textStyle: errorTextStyle,
);
}
Expand Down
1 change: 1 addition & 0 deletions lib/src/chart/line_chart/line_chart_painter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ class LineChartPainter extends AxisChartPainter<LineChartData> {
spot,
Offset(x, y),

Check warning on line 428 in lib/src/chart/line_chart/line_chart_painter.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/chart/line_chart/line_chart_painter.dart#L428

Added line #L428 was not covered by tests
relativeErrorPixelsRect,
holder.data,

Check warning on line 430 in lib/src/chart/line_chart/line_chart_painter.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/chart/line_chart/line_chart_painter.dart#L430

Added line #L430 was not covered by tests
);
}
}
Expand Down
3 changes: 2 additions & 1 deletion lib/src/utils/canvas_wrapper.dart
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ class CanvasWrapper {
FlSpot origin,
Offset offset,
Rect errorRelativeRect,
AxisChartData axisData,
) {
painter.draw(canvas, offset, origin, errorRelativeRect);
painter.draw(canvas, offset, origin, errorRelativeRect, axisData);

Check warning on line 129 in lib/src/utils/canvas_wrapper.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/utils/canvas_wrapper.dart#L129

Added line #L129 was not covered by tests
}

/// Handles performing multiple draw actions rotated.
Expand Down

0 comments on commit 5a0fbfe

Please sign in to comment.