-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOML rotate ops #562
JOML rotate ops #562
Conversation
If this PR is accepted, maybe the |
Cool, thanks @rimadoma! Do you think it would be too general to call the namespace |
I was thinking this name space would be for linear algebra on (simple) vectors and matrices. I think Apache commons calls their package In any case, I see these ops eventually migrating to |
I think |
@ctrueden in the last year or so I've mostly been wrapping BLAS (Basic Linear Algebra Specification), and using a bit of ND4J (N-Dimensionsal Arrays for Java). I'd vote for calling the namespace @rimadoma if you haven't seen it already there is a transform namespace that contains a rotate function. Although this namespace is specific to imglib2 structures. I've also been working a Do you guys think all I also wonder if this functionality belongs in the core imagej-ops project, or should be in a separate |
Do we have/Can we have aliases in the ops world? I also prefer |
@bnorthan All the ops in the |
This imagej/imagej-ops repository needs to be chopped into multiple different repositories before year's end. I agree that putting the JOML ops into their own repository makes sense. Calling the namespace @rimadoma I am going on vacation starting Wednesday for two weeks, so will probably not get to this PR before then. But I will try to make it a priority to merge it before end of August. |
What's your opinion y'all: should this |
@ctrueden Enjoy your vacation! I'll start mine before you come back, and won't return until August 2. |
This is a beautiful PR, so I'm going to merge it. We can deal with the modularization separately as part of the more general modularization of ImageJ Ops. |
LinAlg
namespaceVector3d
andVector3f