-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion between image classes not working #15
Comments
@PetrBainar Did you have time to track this down? If not, I am happy to investigate it. Can you post a quick set of steps here to reproduce the issue? |
@ctrueden We did some investigation on this issue and it can easily be resolved by adding appropriate converters (e.g. from Dataset to ImageDisplay) to the project. However, the outputs resulting from the Command execution are not converted back so you might end up with multiple independent objects (e.g. Dataset and numerous DatasetView objects) corresponding to a single image. We tried to store images as DatasetView objects immediately after upload and had better experience with this approach. Nevertheless, there might be some constrains we are not aware. What was the rationale for choosing Dataset as the type for storing images? |
I had the same probelm, but I don't know where to add the converters, do you have any suggestions? |
A |
Thanks for your advice, it works! |
Converting between various image classes like Dataset, ImageDisplay or DatasetView during module execution is not working properly. For example, when a Dataset object is provided, it is expected to be converted into an ImageDisplay or a DatasetView instance when needed.
However, this is not happening at the moment as ConvertService.convert(...) returns null.
The text was updated successfully, but these errors were encountered: