You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a class named JsonService in the ImageJ Server project. This service however is NOT a SciJava service. Since ImageJ Server relies on SciJava, which has got an own service model, the fact that JsonService is not a SciJava service causes certain confusion.
I think part of the confusion is that the Dropwizard stack has its own service model, so the term "service" becomes technically ambiguous in this project. And further adding to this confusion: I don't think the JsonService is a Dropwizard service either! 😆 It would be nice if someone who takes the time to understand both architectures (SciJava and Dropwizard) could clean up this project.
The text was updated successfully, but these errors were encountered:
PetrBainar
changed the title
Make JsonService a SciJava service
Convert JsonService and other non-SciJava services into SciJava services
Mar 3, 2019
Alternately, the class could just be renamed JsonHelper or JsonFunctions or similar to avoid this confusion. The only reason I can think of to make it a SciJava service would be for extensibility, in case anyone wants to override how those functions work downstream.
There is a class named JsonService in the ImageJ Server project. This service however is NOT a SciJava service. Since ImageJ Server relies on SciJava, which has got an own service model, the fact that JsonService is not a SciJava service causes certain confusion.
@ctrueden pointed out in #30
The text was updated successfully, but these errors were encountered: