Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert JsonService and other non-SciJava services into SciJava services #31

Open
PetrBainar opened this issue Mar 3, 2019 · 1 comment

Comments

@PetrBainar
Copy link
Contributor

There is a class named JsonService in the ImageJ Server project. This service however is NOT a SciJava service. Since ImageJ Server relies on SciJava, which has got an own service model, the fact that JsonService is not a SciJava service causes certain confusion.

@ctrueden pointed out in #30

I think part of the confusion is that the Dropwizard stack has its own service model, so the term "service" becomes technically ambiguous in this project. And further adding to this confusion: I don't think the JsonService is a Dropwizard service either! 😆 It would be nice if someone who takes the time to understand both architectures (SciJava and Dropwizard) could clean up this project.

@PetrBainar PetrBainar changed the title Make JsonService a SciJava service Convert JsonService and other non-SciJava services into SciJava services Mar 3, 2019
@ctrueden
Copy link
Member

ctrueden commented Mar 4, 2019

Alternately, the class could just be renamed JsonHelper or JsonFunctions or similar to avoid this confusion. The only reason I can think of to make it a SciJava service would be for extensibility, in case anyone wants to override how those functions work downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants