Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the New button's ability to make plain NumPy arrays, or at least make xarray the default #277

Closed
ctrueden opened this issue Jul 26, 2023 · 0 comments · Fixed by #312
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ctrueden
Copy link
Member

When running a computer op, the awesome New button lets you make a new output image, which is by default dimensioned the same as the input image. But the default array type is NumPy, meaning it has no dimensional axis metadata, and so the dimensions are lost after performing the calculation. I propose to make the default xarray, or even just use xarray always (I forget what the third option is though; maybe we need to keep it?). The New dialog probably also needs to be enhanced to allow specifying the axis type of each dimension, same as how you can specify the dimensional sizes—and this axis types list should by default match the input image's. This will make it much simpler to execute filter-type ops without losing image metadata.

There is a related question if some of @elevans's work is relevant here. Maybe the input image's properties should transfer over to the output image? It gets quite tricky though, and we may instead want to work on the MetaViews/RichViews and use that somehow; I'm not sure. But just preserving axis labels is for sure something we should do.

@gselzer gselzer self-assigned this Jul 26, 2023
@gselzer gselzer added the enhancement New feature or request label Jul 26, 2023
@gselzer gselzer added this to the 0.2.0 milestone Jul 26, 2023
@gselzer gselzer mentioned this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants