Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Drawer doesn't work properly with stickyHeader #91

Open
khamer opened this issue Jun 26, 2017 · 2 comments
Open

Search Drawer doesn't work properly with stickyHeader #91

khamer opened this issue Jun 26, 2017 · 2 comments

Comments

@khamer
Copy link
Member

khamer commented Jun 26, 2017

Our default setup with both stickyHeader and searchDrawer in use makes it immediately obvious that if you scroll down a bit and pull up the stickyHeader, the searchDrawer opens off screen.

@marcelmoreau
Copy link
Contributor

Workshop ticket created

@marcelmoreau
Copy link
Contributor

trying this out in #103

JTQC pushed a commit that referenced this issue Oct 16, 2017
JTQC pushed a commit that referenced this issue Dec 1, 2017
marcelmoreau added a commit that referenced this issue Dec 3, 2017
 Task #91:  #91: fix the site messaging icons
marcelmoreau pushed a commit that referenced this issue Dec 3, 2017
* gh-pages:
  Task #91:  #91: fix the site messaging icons
  add class while element is stuck
  Task #91:  #91: fix the site messaging icons
  deleting searchDrawer js plugin and adding it into our sticky header plugin; ensuring search drawer is visible when you are down a ways on a page

# Conflicts:
#	css/styles.css
#	css/styles.css.map
#	css/styles.scss
marcelmoreau added a commit that referenced this issue Mar 20, 2018
 Task #91:  #91: fix the site messaging icons
marcelmoreau pushed a commit that referenced this issue Mar 20, 2018
* gh-pages:
  Task #91:  #91: fix the site messaging icons
  add class while element is stuck
  Task #91:  #91: fix the site messaging icons
  deleting searchDrawer js plugin and adding it into our sticky header plugin; ensuring search drawer is visible when you are down a ways on a page

# Conflicts:
#	css/styles.css
#	css/styles.css.map
#	css/styles.scss
marcelmoreau pushed a commit that referenced this issue Mar 20, 2018
* gh-pages:
  fixes to header primary’s search drawer
  Fieldset guideline corrections
  Change font stack back to original
  Import normalize-scss npm module. Re-build and commit css files, map and package.json
  Add second colon for a pseudo elements
  Remove commented code in Base area
  Normalize as a reset
  Task #91:  #91: fix the site messaging icons

# Conflicts:
#	css/app.css
#	css/styles.css.map
#	demo/dropdown-simple.html
#	index.html
#	package-lock.json
#	package.json
#	resources/assets/sass/app.scss
marcelmoreau pushed a commit that referenced this issue Mar 20, 2018
* gh-pages:
  fixes to header primary’s search drawer
  Fieldset guideline corrections
  Change font stack back to original
  Import normalize-scss npm module. Re-build and commit css files, map and package.json
  Add second colon for a pseudo elements
  Remove commented code in Base area
  Normalize as a reset
  Task #91:  #91: fix the site messaging icons

# Conflicts:
#	css/app.css
#	css/styles.css.map
#	demo/dropdown-simple.html
#	index.html
#	package-lock.json
#	package.json
#	resources/assets/sass/app.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants