Fix HDF5 implicit copy (BlueQuartzSoftware#920)

Delete copy constructors in HDF5 parsing classes.
Fixed DatasetIO move constructor.

fixes BlueQuartzSoftware#916

src/simplnx/Utilities/Parsing/HDF5/IO/AttributeIO.hpp

@@ -37,6 +37,9 @@ class SIMPLNX_EXPORT AttributeIO
    */
   AttributeIO(IdType objectId, const std::string& attrName);
 
+  AttributeIO(const AttributeIO& other) = delete;
+  AttributeIO(AttributeIO&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 attribute.
    */
@@ -164,6 +167,9 @@ class SIMPLNX_EXPORT AttributeIO
   template <typename T>
   Result<> writeVector(const DimsVector& dims, const std::vector<T>& vector);
 
+  AttributeIO& operator=(const AttributeIO& other) = delete;
+  AttributeIO& operator=(AttributeIO&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/IO/DatasetIO.cpp

@@ -24,7 +24,7 @@ DatasetIO::DatasetIO(IdType parentId, const std::string& datasetName)
 }
 
 DatasetIO::DatasetIO(DatasetIO&& other) noexcept
-: ObjectIO(other)
+: ObjectIO(std::move(other))
 , m_DatasetName(std::move(other.m_DatasetName))
 {
 }

src/simplnx/Utilities/Parsing/HDF5/IO/FileIO.hpp

@@ -61,6 +61,8 @@ class SIMPLNX_EXPORT FileIO : public GroupIO
    */
   FileIO(IdType fileId);
 
+  FileIO(const FileIO& rhs) = delete;
+
   /**
    * @brief Move constructor.
    * @param rhs
@@ -79,6 +81,9 @@ class SIMPLNX_EXPORT FileIO : public GroupIO
    */
   std::string getName() const override;
 
+  FileIO& operator=(const FileIO& rhs) = delete;
+  FileIO& operator=(FileIO&& rhs) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/IO/GroupIO.hpp

@@ -21,6 +21,9 @@ class SIMPLNX_EXPORT GroupIO : public ObjectIO
    */
   GroupIO(IdType parentId, const std::string& groupName);
 
+  GroupIO(const GroupIO& other) = delete;
+  GroupIO(GroupIO&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 group.
    */
@@ -135,6 +138,9 @@ class SIMPLNX_EXPORT GroupIO : public ObjectIO
    */
   bool isDataset(const std::string& childName) const;
 
+  GroupIO& operator=(const GroupIO& other) = delete;
+  GroupIO& operator=(GroupIO&& other) noexcept = default;
+
 protected:
   /**
    * @brief Constructs a GroupWriter for use in derived classes. This

src/simplnx/Utilities/Parsing/HDF5/IO/ObjectIO.hpp

@@ -26,6 +26,9 @@ class SIMPLNX_EXPORT ObjectIO
    */
   ObjectIO(IdType parentId, const std::string& targetName);
 
+  ObjectIO(const ObjectIO& other) = delete;
+  ObjectIO(ObjectIO&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 object.
    */
@@ -128,6 +131,9 @@ class SIMPLNX_EXPORT ObjectIO
    */
   AttributeIO createAttribute(const std::string& name);
 
+  ObjectIO& operator=(const ObjectIO& other) = delete;
+  ObjectIO& operator=(ObjectIO&& other) noexcept = default;
+
 protected:
   /**
    * @brief Constructs an ObjectIO for use in derived classes. This

src/simplnx/Utilities/Parsing/HDF5/Readers/AttributeReader.hpp

@@ -36,6 +36,9 @@ class SIMPLNX_EXPORT AttributeReader
    */
   AttributeReader(IdType objectId, const std::string& attrName);
 
+  AttributeReader(const AttributeReader& other) = delete;
+  AttributeReader(AttributeReader&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 attribute.
    */
@@ -146,6 +149,9 @@ class SIMPLNX_EXPORT AttributeReader
    */
   std::string readAsString() const;
 
+  AttributeReader& operator=(const AttributeReader& other) = delete;
+  AttributeReader& operator=(AttributeReader&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/Readers/DatasetReader.hpp

@@ -27,6 +27,9 @@ class SIMPLNX_EXPORT DatasetReader : public ObjectReader
    */
   DatasetReader(IdType parentId, const std::string& dataName);
 
+  DatasetReader(const DatasetReader& other) = delete;
+  DatasetReader(DatasetReader&& other) noexcept = default;
+
   /**
    * @brief Releases the HDF5 dataset.
    */
@@ -122,6 +125,9 @@ class SIMPLNX_EXPORT DatasetReader : public ObjectReader
 
   std::string getFilterName() const;
 
+  DatasetReader& operator=(const DatasetReader& other) = delete;
+  DatasetReader& operator=(DatasetReader&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/Readers/FileReader.hpp

@@ -26,6 +26,9 @@ class SIMPLNX_EXPORT FileReader : public GroupReader
    */
   FileReader(IdType fileId);
 
+  FileReader(const FileReader& other) = delete;
+  FileReader(FileReader&& other) noexcept = default;
+
   /**
    * @brief Releases the HDF5 file ID.
    */
@@ -38,6 +41,9 @@ class SIMPLNX_EXPORT FileReader : public GroupReader
    */
   std::string getName() const override;
 
+  FileReader& operator=(const FileReader& other) = delete;
+  FileReader& operator=(FileReader&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/Readers/GroupReader.hpp

@@ -19,6 +19,9 @@ class SIMPLNX_EXPORT GroupReader : public ObjectReader
    */
   GroupReader(IdType parentId, const std::string& groupName);
 
+  GroupReader(const GroupReader& other) = delete;
+  GroupReader(GroupReader&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 group.
    */
@@ -87,6 +90,9 @@ class SIMPLNX_EXPORT GroupReader : public ObjectReader
    */
   bool isDataset(const std::string& childName) const;
 
+  GroupReader& operator=(const GroupReader& other) = delete;
+  GroupReader& operator=(GroupReader&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/Readers/ObjectReader.hpp

@@ -24,6 +24,9 @@ class SIMPLNX_EXPORT ObjectReader
    */
   ObjectReader(IdType parentId, const std::string& targetName);
 
+  ObjectReader(const ObjectReader& other) = delete;
+  ObjectReader(ObjectReader&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 object.
    */
@@ -96,6 +99,9 @@ class SIMPLNX_EXPORT ObjectReader
    */
   AttributeReader getAttributeByIdx(size_t idx) const;
 
+  ObjectReader& operator=(const ObjectReader& other) = delete;
+  ObjectReader& operator=(ObjectReader&& other) noexcept = default;
+
 protected:
   /**
    * @brief Constructs an ObjectReader for use in derived classes. This

src/simplnx/Utilities/Parsing/HDF5/Writers/AttributeWriter.hpp

@@ -31,6 +31,9 @@ class SIMPLNX_EXPORT AttributeWriter
    */
   AttributeWriter(IdType objectId, const std::string& attributeName);
 
+  AttributeWriter(const AttributeWriter& other) = delete;
+  AttributeWriter(AttributeWriter&& other) noexcept = default;
+
   /**
    * @brief Default destructor
    */
@@ -204,6 +207,9 @@ class SIMPLNX_EXPORT AttributeWriter
     return returnError;
   }
 
+  AttributeWriter& operator=(const AttributeWriter& other) = delete;
+  AttributeWriter& operator=(AttributeWriter&& other) noexcept = default;
+
 protected:
   /**
    * @brief Finds and deletes any existing attribute with the current name.

src/simplnx/Utilities/Parsing/HDF5/Writers/DatasetWriter.hpp

@@ -28,6 +28,9 @@ class SIMPLNX_EXPORT DatasetWriter : public ObjectWriter
    */
   DatasetWriter(IdType parentId, const std::string& datasetName);
 
+  DatasetWriter(const DatasetWriter& other) = delete;
+  DatasetWriter(DatasetWriter&& other) noexcept = default;
+
   /**
    * @brief Default destructor
    */
@@ -203,6 +206,9 @@ class SIMPLNX_EXPORT DatasetWriter : public ObjectWriter
    */
   IdType getPListId() const;
 
+  DatasetWriter& operator=(const DatasetWriter& other) = delete;
+  DatasetWriter& operator=(DatasetWriter&& other) noexcept = default;
+
 protected:
   /**
    * @brief Finds and deletes any existing attribute with the current name.

src/simplnx/Utilities/Parsing/HDF5/Writers/FileWriter.hpp

@@ -36,6 +36,12 @@ class SIMPLNX_EXPORT FileWriter : public GroupWriter
    */
   FileWriter();
 
+  /**
+   * @brief Copy constructor.
+   * @param rhs
+   */
+  FileWriter(const FileWriter& rhs) = delete;
+
   /**
    * @brief Move constructor.
    * @param rhs
@@ -54,6 +60,9 @@ class SIMPLNX_EXPORT FileWriter : public GroupWriter
    */
   std::string getName() const override;
 
+  FileWriter& operator=(const FileWriter& rhs) = delete;
+  FileWriter& operator=(FileWriter&& rhs) noexcept = default;
+
 protected:
   /**
    * @brief Constructs a FileWriter that creates and wraps an HDF5 file at the

src/simplnx/Utilities/Parsing/HDF5/Writers/GroupWriter.hpp

@@ -24,6 +24,9 @@ class SIMPLNX_EXPORT GroupWriter : public ObjectWriter
    */
   GroupWriter(IdType parentId, const std::string& objectName);
 
+  GroupWriter(const GroupWriter& other) = delete;
+  GroupWriter(GroupWriter&& other) noexcept = default;
+
   /**
    * @brief Closes the HDF5 group.
    */
@@ -62,6 +65,9 @@ class SIMPLNX_EXPORT GroupWriter : public ObjectWriter
    */
   Result<> createLink(const std::string& objectPath);
 
+  GroupWriter& operator=(const GroupWriter& other) = delete;
+  GroupWriter& operator=(GroupWriter&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.

src/simplnx/Utilities/Parsing/HDF5/Writers/ObjectWriter.hpp

@@ -25,6 +25,9 @@ class SIMPLNX_EXPORT ObjectWriter
    */
   ObjectWriter(IdType parentId, IdType objectId = 0);
 
+  ObjectWriter(const ObjectWriter& other) = delete;
+  ObjectWriter(ObjectWriter&& other) noexcept = default;
+
   /**
    * @brief Releases the wrapped HDF5 object.
    */
@@ -90,6 +93,9 @@ class SIMPLNX_EXPORT ObjectWriter
    */
   AttributeWriter createAttribute(const std::string& name);
 
+  ObjectWriter& operator=(const ObjectWriter& other) = delete;
+  ObjectWriter& operator=(ObjectWriter&& other) noexcept = default;
+
 protected:
   /**
    * @brief Closes the HDF5 ID and resets it to 0.