-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vitessce-image-viewer layer #19
Open
oeway
wants to merge
21
commits into
master
Choose a base branch
from
add-viv-viewer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for kaibu ready! Built with commit 2502d68 |
This was referenced Aug 14, 2020
oeway
force-pushed
the
add-viv-viewer
branch
from
September 17, 2020 17:24
5aba2f2
to
b8bdd92
Compare
Support UI widgets
Support tree widget
Support cutting polygons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After exploring the vitessce-image-viewer by @ilan-gold and @manzt et. al, I am super excited about the work, particularly because it opens up new way of interacting large amount of data directly in the browser. From this discussion, the avenue of vitessce is highly inline with what we are trying to build with ImJoy, Kaibu, and the ongoing collaboration with itk-vtk-viewer (@thewtex ). Would be great to joint effort and make something even better.
As a first step, I think it would be great to integrate the vitessce-image-viewer as a layer to Kaibu. And we can also reuse the ZarrLoader, Pyramid manager etc. for other part of Kaibu.
Here is a list of things to implement:
PictureInPictureViewer
from vitessce-image-viewer(Viv) and use it as a vue component ( because Viv is made from React, we need to use vuera to wrap it as a vue component.)