Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textures of some vehicles flickering #86

Open
CrosRoad95 opened this issue Apr 19, 2020 · 3 comments
Open

Textures of some vehicles flickering #86

CrosRoad95 opened this issue Apr 19, 2020 · 3 comments
Labels
bug Something isn't working importing Related to importing orginal game assets into Unity rendering vehicles

Comments

@CrosRoad95
Copy link

CrosRoad95 commented Apr 19, 2020

as on image

MULE:
image

BENSON:
image

@CrosRoad95 CrosRoad95 changed the title MULE vehicle texture flickering Textures of some vehicles flickering Apr 19, 2020
@in0finite in0finite added bug Something isn't working vehicles importing Related to importing orginal game assets into Unity rendering labels Apr 19, 2020
@atirut-w
Copy link
Contributor

I think this might be caused by loading all the signs and them being in the exact same place.

@GoverLabs
Copy link
Contributor

Hello
I've take a look at the issue. Seems it is caused because no "extra" was chosen for vehicle.
E.g. on the MULE there are 4 extras for chasis, and one random should be choosen. It works fine when only one of them is enabled.
image

Another example is STALLION, wich have several "extra" for its roof, it also have some precondition, how to choose the correct one. Preconditions are described in Comprules in vehicles.ide.
image

https://gtamods.com/wiki/CARS_(IDE_Section)#Comprules

I can investigate it more and fix the issue like my "first simple one".

@in0finite
Copy link
Owner

@GoverLabs that was very well investigated 👍 I wasn't even aware of these "extras". Yeah, this seems like a good issue to start with.

Having a look at the wiki page, I found there is a bit more to it than described. They have a link at bottom which leads to: https://gtaforums.com/topic/530575-tutcomponent-rules/ . There is more detailed explanation how it works.

We already have CARS ide section parsed, it's in VehicleDef.cs. So basically, all we need to do is, when creating a vehicle, check the VehicleDef.CompRules and enable corresponding "extra" object. This would probably be done in Vehicle.Initialize().

You can also send me PM in discord for quicker response.

GoverLabs added a commit to GoverLabs/SanAndreasUnity that referenced this issue Jul 17, 2022
…eDef.CompRules

fix flickering textures on vehicles, containing extra components in0finite#86
in0finite pushed a commit that referenced this issue Jul 17, 2022
* implemented extra compontents selection for vehicles, based on VehicleDef.CompRules
fix flickering textures on vehicles, containing extra components #86

* fixed tabs

* replaced CompRulesUnion fields by a single field and corresponding getters
fixed minor copy-paste issues

* fixed minor copy-paste issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working importing Related to importing orginal game assets into Unity rendering vehicles
Projects
None yet
Development

No branches or pull requests

4 participants