Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having images in the Guide open in a modal #64

Open
jhung opened this issue Aug 16, 2021 · 1 comment
Open

Consider having images in the Guide open in a modal #64

jhung opened this issue Aug 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jhung
Copy link
Member

jhung commented Aug 16, 2021

Is your feature request related to a problem?

Currently, when an image is selected (e.g. Virtuous Cycles diagram, or Inclusive Design Mapping figures), the image is rendered by loading the image URL in the browser. To go back to the content, one must use the browser's back button.

Originally filed as FLOE-517

Describe the solution you'd like

In some situations, it may be better that the image load in a modal which is displayed in context of the content, and the user selects "Close" or selects outside the modal to dismiss it.

Additional context or notes

This modal implementation will have consequences for accessibility (see Accessible Modal Dialogs). Also these modals may be confusing on mobile devices where the modal takes up nearly 100% of the space (in these situations does navigating back close the image, or does the user have to select "Close?).

@jhung jhung added the enhancement New feature or request label Aug 16, 2021
@Au005515

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants