Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Design Guide category tabs stacking and hamburger menu transition #70

Open
Tracked by #84 ...
jhung opened this issue Aug 20, 2021 · 2 comments
Open
Tracked by #84 ...
Labels
bug Something isn't working

Comments

@jhung
Copy link
Member

jhung commented Aug 20, 2021

Describe the bug

When the client window shrinks, the categories on the Guide stack from 4 in a row to 3x1, before jumping to a hamburger menu.

Originally filed as part of FLOE-478

Expected behavior

Consider the switch to hamburger earlier to avoid the 3x1 stacking, or get rid of hamburger menu all together and keep the category tabs.

Screenshots

image

image

Additional context or notes

Some prototyping may be required to try different approaches which should be reviewed by designers.

@jhung jhung added the bug Something isn't working label Aug 20, 2021
@jobara jobara mentioned this issue Sep 29, 2021
8 tasks
@jhung
Copy link
Member Author

jhung commented Oct 15, 2021

In talking with @jobara, we think that this issue is difficult to fix given the current visual style. The skeuomorphic "tab" design does not scale well with different screen sizes and text string (especially with long translations).

We are suggesting that the tab style navigation be redesigned so any wrapping does not break the visual style.

@jhung jhung mentioned this issue Oct 15, 2021
8 tasks
@jobara
Copy link
Member

jobara commented Oct 18, 2021

@jhung in thinking about the issue this morning, until a redesign occurs, we may want to explore preventing wrapping completely. In those case we could do one or more of the following:

Considering that we only have languages at the moment you could also selectively apply or vary the approach to work best with each language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants