New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API improvements/breaking changes: NewXyzCommand should not need commandID #47

Open

longquanzheng opened this issue Feb 8, 2023 · 1 comment

Contributor

longquanzheng commented Feb 8, 2023

This includes:

NewTimerCommand
NewSignalCommand
NewInterstateChannelCommand

Most of the time people don't need to use commandId.

We can create new APIs for using commandID:

NewTimerCommandWithId
NewSignalCommandWithId
NewInterstateChannelCommandWithId

Contributor Author

longquanzheng commented Feb 9, 2023

Alternatively make NewTimerCommandByDuration NewSignalCommandByChannel etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment