IWF-137: Update iwf-idl to latest to allow to use separate persistency loading policy for waitUntil

[samuel27m]

Description

Updating iwf-idl to latest to: Allow to use separate persistency loading policy for waitUntil
Depends on indeedeng/iwf#448

Checklist

• Code compiles correctly
• Tests for the changes have been added
• All tests passing
• This PR change is backwards-compatible
• This PR CONTAINS a (planned) breaking change (it is NOT backwards-compatible)

Related Issue

Closes indeedeng/iwf#387

[longquanzheng]

Nit: maybe modify/add an new test to use the new field

[samuel27m]

Nit: maybe modify/add an new test to use the new field

I agree with you, but I can't add any new tests before before the iwf server MR, they would fail until we merge those. I can get something going now, so that once we merge those re-run the pipeline would make them pass, but they wouldn't pass for now.

[samuel27m]

A RpcTest is failing in this MR but they all pass locally for me, unsure what is going on:

RpcTest > testRPCLocking() FAILED
    org.opentest4j.AssertionFailedError at RpcTest.java:90

[longquanzheng]

A RpcTest is failing in this MR but they all pass locally for me, unsure what is going on:

RpcTest > testRPCLocking() FAILED
    org.opentest4j.AssertionFailedError at RpcTest.java:90

testRPCLocking is flacky becuase it's agressively doing locking, I guess it's someitmes overloading the docker iwf-servier(temporal)...we need to improve it later. For now, I usually just rerun it

[longquanzheng]

Nit: maybe modify/add an new test to use the new field

I agree with you, but I can't add any new tests before before the iwf server MR, they would fail until we merge those. I can get something going now, so that once we merge those re-run the pipeline would make them pass, but they wouldn't pass for now.

I approved your server change!

[samuel27m]

Added now a new Integration Test 🚀
The one test failing is still the RPCLocking test

[longquanzheng]

Added now a new Integration Test 🚀 The one test failing is still the RPCLocking test

Oh okay, I think I found the problems, after looking at dump docker logs for iwf-server:lastest.
Basically @lwolczynski has upgraded the temporal SDK in iwf-server which now requires newer version of Temporal server.

So we have to upgrade the env here:

See in
https://github.com/indeedeng/iwf-java-sdk/tree/main/script

you will need to change

• https://github.com/indeedeng/iwf-java-sdk/blob/main/script/.env
• https://github.com/indeedeng/iwf-java-sdk/blob/main/script/docker-compose-init.sh
• and https://github.com/indeedeng/iwf-java-sdk/blob/main/script/docker-compose.yml
  to match IWF-186: Upgrade Temporal SDK iwf#442

We should also do this for Golang/Python SDK as well. Golang's script is in https://github.com/indeedeng/iwf-golang-sdk/tree/main/integ and Python in https://github.com/indeedeng/iwf-python-sdk/tree/main/iwf/tests/iwf-service-env

[samuel27m]

Alright, that makes sense. I'm going to create a new ticket to merge these upgrades. I don't think they should be included as part of the current ticket changes.

[longquanzheng]

Alright, that makes sense. I'm going to create a new ticket to merge these upgrades. I don't think they should be included as part of the current ticket changes.

Yes that's a good idea

[samuel27m]

Perfect, the failing test is fixed now, thanks so much Long for looking into it! Appreciated.
I'll merge this MR on Monday 👍