Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests were lazily written and not comprehensive #1

Open
3 tasks
indomitableSwan opened this issue Mar 21, 2024 · 1 comment
Open
3 tasks

Tests were lazily written and not comprehensive #1

indomitableSwan opened this issue Mar 21, 2024 · 1 comment

Comments

@indomitableSwan
Copy link
Owner

  • Encoding/Decoding tests
  • Encryption/Decryption tests
  • Randomness-related tests
@indomitableSwan
Copy link
Owner Author

Note that the bug fixed in b02895c was noticed because the doc tests were picking random keys, i.e., were not reproducible tests.

indomitableSwan added a commit that referenced this issue Jul 20, 2024
@indomitableSwan
Writing failing test for encryption/decryption, caused by lack of val…
552237a 
…idation in RingElement construction. Relates to #1
indomitableSwan added a commit that referenced this issue Jul 24, 2024
@indomitableSwan
Writing failing test for encryption/decryption, caused by lack of val…
3753d3c 
…idation in RingElement construction. Relates to #1
indomitableSwan added a commit that referenced this issue Jul 25, 2024
@indomitableSwan
Clean up error handling, part one (#35)
7e16b04 
* refactor using thiserror crate

* Created an opaque error type to hide internal error representation details

* Collected internal errors under one private enum `ErrorRepr` for future use

* rewrite error messages and attach context to public types for greater clarity

* Internal code cleanup where possible (simplifying code, reorganization for better readability, making more idiomatic)

* reduce code duplication in demo by adding trait bounds to the parser helper 
`process_input` requiring the output type's `FromStr` Error  to implement `Display`. This also allows the demo writer to pass through errors from the crypto library transparently instead of rewriting similar content.

* Add tests:
  *Writing failing test for encryption/decryption, caused by lack of validation in RingElement construction. Relates to #1. This test only works within the library bc `RingElement` is private.
  * add test that demonstrates expected, but potentially surprising behavior reading RingElements from i8s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@indomitableSwan