Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosts & Accessible Server Instance (and tests) #50

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

drewdotpro
Copy link

@drewdotpro drewdotpro commented Jul 19, 2016

Feature: Host can be set in options.
Feature: The server instance, with .address() function etc is passed back on master(old: master=false worker=true, new: master=serverInstance, worker=false) - this only happens if you set options.returnInstance to true, otherwise it is 'classis style'.
Existing tests have been updated to manage async issues.
2 new tests (for the 2 new features) have been added.

While net.Server supports defining a host, Master did not. Now it does.
Support host definiton within options
Feature: The server instance, with .address() function etc is passed back on master(old: master=false worker=true, new: master=serverInstance, worker=false) - this only happens if you set options.returnInstance to true, otherwise it is 'classis style'.
Existing tests have been updated to manage async issues.
2 new tests (for the 2 new features) have been added.
 test.sh added to run all the tests synchronously
@drewdotpro
Copy link
Author

Is this repo no longer maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant