Fixing invalid / misspelled / unknown allegiance codes in sector data #239
Conversation
Sometimes custom allegiance codes are contained in world data without matching allegiances in sector xml. This leads to not being printed in metadata of surveys => added codes with description "(Unknown)" to sector xml
Allegiances are sometimes not matching to those in sector xml.
In many cases sector data contains allegiance code Nx without matching allegiance in sector xml => changed Nx to NaXX, as this is know in 'allegiance_code.tab'
There was a problem hiding this comment.
This PR is too large to review. Please break it down into separate PRs for specific problems; ideally one per sector unless there are consistent issues across all files within a directory.
Also, please ensure that all sector files have been validated using travellermap.com/tools/lintsec before submitting.
Also note that there's no requirement that 2-character allegiance codes used in legacy files be consistent across sectors. Be sure you're not making unnecessary changes. Include details about (1) the perceived problem (it may not be obvious, and/or it may not actually be a problem and (2) the proposed fix as part of the PR description.
| 0102 Jorutha ?311???-? Ic Tz - - - ?11 8 NaXX M4 V |
There was a problem hiding this comment.
With the header untouched this is invalid. Make sure to use travellermap.com/tools/lintsec to validate any updated data.
| @@ -74,7 +74,7 @@ Picket 1103 B242361-A N Lo Mr Po G 601 An K1 V M7 V | |||
| Klathe 1106 D879361-A Lo Re G 801 An K7 IV | |||
| Vanzyke 1110 D100261-A Lo Re Va G 301 An M8 VI DM | |||
| Baza 1111 C579363-B Lo Re G 223 An F6 V | |||
| San Venaco 1122 E3433A7-5 Po Lo G 230 IN K8 V M3 VI | |||
| San Venaco 1122 E3433A7-5 Po Lo G 230 In K8 V M3 VI | |||
| @@ -41,11 +41,11 @@ Hex Name UWP Remarks | |||
| 0907 Ktuamat E777524-6 Ag Ni - - - 203 K4 K3 IV K5 V | |||
| 0909 Ltikrua B7B0669-B He Ni O:1107 - - - 823 K4 M1 V M9 V | |||
| 0910 Naa Paghti C555A88-A Hi - - - 123 K4 G8 V | |||
| 1003 Tagn'akan A200557-D Ni Va GiruW - K - 404 Kc M7 V M1 V | |||
| 1003 Tagn'akan A200557-D Ni Va GiruW - K - 404 Kk M7 V M1 V | |||
There was a problem hiding this comment.
These are intentional K'kree client states.
|
will break it down into smaller chunks for review |
|
closing for breaking down into smaller chunks |
Sector data contains a lot of invalid / misspelled / unknown allegiance codes. In surveys this leads to a not complete Alleg section in metadata.
Expectation is, that used codes in a sector's world data should be displayed as allegiances in Alleg section in sector data. As far as I can see, this is exactly your implementation.
Types of invalid codes are different. Sometimes these are simply misspelled wrt casing. Others are completely unknown and not defined in related sector xml. In a different case, allegiance code is different from the one in 'allegiance_code.tab' (e.g. Nx and NaXX). In the latter case generally known code should be used.
Examples:
This pull request fixes issue 240