Define fingerprint to distinguish runs #27
Conversation
| # Defines the description of the run on the JSON output. | ||
| # We utilize this value to distinguish between server version and cache configuration on Horreum. | ||
| # By default, it can be null. If running the complete test suite, it is automatically filled. | ||
| hyperfoil_run_description: '' |
There was a problem hiding this comment.
In the past I have had to put "{{ undef() }}" does it work with empty string?
There was a problem hiding this comment.
It was working, but I'll update it to "{{ undef() }}" for consistency.
But I see this weird thing when running the all_benchmarks.yml playbook. If I don't explicitly set the server_image value, the hyperfoil_run_description remains null. If I set the server_image to something, even the same value as the default, the description is created correctly.
| # Optional way to override the server image used by the benchmar | ||
| server_image: quay.io/infinispan/server | ||
| # Optional way to override the server image used by the benchmark | ||
| server_image: "quay.io/infinispan/server:15.0" |
There was a problem hiding this comment.
I don't know if we want to change this default or not... User should probably override instead if they want a specific version.
| @@ -17,6 +17,7 @@ | |||
| run_once: true | |||
| vars: | |||
| operation: run | |||
| hyperfoil_run_description: "{{ server_image }}-{{ cache_file }}" | |||
There was a problem hiding this comment.
This isn't descriptive enough, but I guess it is probably fine as a default value designed to be overridden by the user.
There was a problem hiding this comment.
Do we include something more here? I intended to leave this "as is" when running in the GH actions.
In Horreum, we utilize a fingerprint to identify which configurations should be tracked for changes. This allows us to test different configurations, with different server versions without needing to create a test for each on Horreum.
I am setting the server image to the
15.0stream which should be the latest stable. Otherwise, it would always return:latesttag.