Fixes for native profiles and java invocations #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galderz
force-pushed
the
t_fix_cli_java_26
branch
from
bdef747
to
2021dcc
Compare
* A workaround to keep `mvn ... -Dnative` working as expected, while it easily offers a way to build native passing in -Dquarkus.native.additional-build-args via command line. * Additional build args via command line can help pass in diverse debugging and profiling options.
galderz
force-pushed
the
t_fix_cli_java_26
branch
from
2021dcc
to
53ec46a
Compare
ryanemerson
force-pushed
the
master
branch
2 times, most recently
from
782a2b7
to
346a97e
Compare
ryanemerson
force-pushed
the
master
branch
7 times, most recently
from
8fba4fe
to
9dd2ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26 and #38
For #26, added an extra profile called
native-noargsto make it easy to build native along with command line provided options. Example usages are:-Dquarkus.native.additional-build-args=-H:+PrintAnalysisCallTree-Dquarkus.native.additional-build-args=--debug-attach=8000-Dquarkus.native.additional-build-args=-H:-DeleteLocalSymbols,-H:+PreserveFramePointerAs it stands, any uses of
-Dnative-noargswould also require adding--allow-incomplete-classpathto the examples above, e.g.-Dquarkus.native.additional-build-args=-H:+PrintAnalysisCallTree,--allow-incomplete-classpath.For #38, made sure that
javainvocations are relative toJAVA_HOME.