Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade RestSharp to 111.4.0 #650

Merged
merged 2 commits into from
Jul 23, 2024
Merged

chore(deps): upgrade RestSharp to 111.4.0 #650

merged 2 commits into from
Jul 23, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 22, 2024 •
edited
Loading

Closes #647

Proposed Changes

This PR upgrade RestSharp to 111.4.0 and also migrate our API to new APIs from RestSharp.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review July 22, 2024 09:41
@bednar bednar mentioned this pull request Jul 22, 2024
Closed
@bednar bednar requested a review from karel-rehor July 22, 2024 09:44
karel-rehor
karel-rehor approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Noticed a few minor style issues discussed off-line. Since this project is only in maintenance mode, we can leave them as is. Latest changes all make sense.

@bednar bednar merged commit afeb626 into master Jul 23, 2024
16 checks passed
@bednar bednar deleted the RestSharp-111.3.0 branch July 23, 2024 13:17
@bednar bednar added this to the 4.17.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karel-rehor karel-rehor karel-rehor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

Client package has old RestSharp depended nuget and rest sharp make api changes that cause an error
2 participants
@bednar @karel-rehor