feature/compartment

[sbhagate-infoblox]

No description provided.

[drewwells]

I like that the key is a string. Consumers can write their own getters. Let's get rid of the multivarient thing that account_id uses. The context key is var string = "compartment_id" no reason to support any other key.

[drewwells]

Suggested change

	multiCompartmentVariants = []string{
	MultiCompartmentField,
	"CompartmentID",
	}

Let's not do this. You have defined the field name as compartment_id, there's no reason for it to then attempt to read CompartmentID. I have no idea why AccountID supports two variations, probably backwards compatibility to dead code

[drewwells]

Suggested change

	for _, compartmentField := range multiCompartmentVariants {
	val, err = GetJWTField(ctx, compartmentField, keyfunc)
	if err == nil {
	return val, nil
	}
	}
	if err == errMissingField {
	return val, nil
	}
	return val, err
	return GetJWTField(ctx, compartmentField, keyfunc)

[drewwells]

This does the same thing. Guess I'm fine with ignoring missing compartment errors.

Suggested change

	var val string
	var err error
	val, err = GetJWTField(ctx, MultiCompartmentField, keyfunc)
	if err == nil || err == errMissingField {
	return val, nil
	} else {
	return val, err
	}
	val, err := GetJWTField(ctx, MultiCompartmentField, keyfunc)
	if err == errMissingField {
	return "", nil
	}
	return val, err