Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific version of go-trees is not targeted in glide.yaml #167

Open
ZachEddy opened this issue Apr 24, 2018 · 0 comments
Open

Specific version of go-trees is not targeted in glide.yaml #167

ZachEddy opened this issue Apr 24, 2018 · 0 comments

Comments

@ZachEddy
Copy link

Target Specific Version of go-trees

I'm working on an application that vendors the PEP, PDP, and PDP Service packages. When I rebuild my vendor tree, I now get the following errors (just started happening yesterday).

infobloxopen/themis/pdp/attribute.go:159:24: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/attribute.go:248:13: undefined: domaintree.MakeWireDomainNameLower
infobloxopen/themis/pdp/attribute.go:289:41: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/attribute.go:405:35: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/attribute.go:411:14: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/attribute.go:481:15: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/content.go:1001:35: undefined: domaintree.WireDomainNameLower
infobloxopen/themis/pdp/context.go:249:60: undefined: domaintree.WireDomainNameLower

These errors seem related to recent changes in the in go-trees repository. Because these changes in go-trees are backward incompatible, I think Themis should target a specific commit of go-trees in the glide.yaml file.

# glide.yaml
- package: github.com/infobloxopen/go-trees
  version: ba3cf0abf6c4176275bfdabf40f4da38da29becb # <-- target a specific commit
  subpackages:
  - domaintree
  - strtree
  - iptree

By adding this to the glide.yaml file, my dependency management tool will recognize that it needs to pull an older version of go-trees that won't break Themis.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant