error when scrivito is not loaded

[marcelgo]

When using the widget and having scrivito.js only included for logged in users, this line causes a "scrivito is not defined error":

https://github.com/Scrivito/scrivito_google_maps_widget/blob/master/app/assets/javascripts/scrivito_google_maps_widget/editing.js.coffee#L36

[gertimon]

Problem here is, that this scrivito code is for the widget reload after changing content. Without the page has to be reloaded. So it would lead to a code like:

if scrivito_is_present
  scrivito.on(content, ...)
else
  $(document).ready(...)
end

This doubled code will be in every widget gem using js and can not be bind automatically to dynamic dom elements.

[marcelgo]

Sorry, but I don't understand this? In my first thinking scrivito?.on... would solve this issue?

[cedrics]

@marcelgo You can safely include scrivito.js even for non logged in user. It is a very short file and will provide scrivito.on and scrivito.in_editable_view when the Scrivito UI is not open (as very simple implementation). The scrivito.js file should only contain the whole code of the referenced file. I marked the code that provides scrivito.on for you. https://github.com/infopark/rails_connector/blob/master/js/src/boot_up.es6.js#L33-L47.

[marcelgo]

@cedrics thank you and I agree that the current version of the file is very short, but this does not have to be the case in the future. In generell I don’t want to do something because it’s safely possible. I want to do things that make sense. And it does not make sense to include files that are not used. Solving the issue with adding a ? looks relatively easy to me. Another option would be to provide different 2 different manifest-files with the gem, which can be included when necessary.

[marcelgo]

Any news on this issue?

[marcelgo]

@gertimon we still have the iframe use case requiring this to be solved. When you have the case, that the customer wants to include the website as an iframe into another page.

Would be great if you could solve this one. Also for the other widgets like the twitter widget.