Add support for Namada #3705
Open
Add support for Namada #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1-namada Update yuji 1.7.1 namada
ljoss17
reviewed
Oct 16, 2024
crates/relayer/src/chain/namada.rs
Outdated
| .latest_block_time | ||
| .to_string() | ||
| .parse() | ||
| .unwrap()) |
There was a problem hiding this comment.
The error should be upstreamed instead of calling unwrap()
crates/relayer/src/chain/namada.rs
Outdated
| if key.to_string().ends_with("clientState") { | ||
| let client_id = | ||
| storage::client_id(&key).map_err(|e| Error::query(e.to_string()))?; | ||
| let client_id = ClientId::from_str(&client_id.to_string()).unwrap(); |
There was a problem hiding this comment.
The error should be upstreamed instead of calling unwrap()
crates/relayer/src/chain/namada.rs
Outdated
| let PrefixValue { key, value: _ } = prefix_value; | ||
| match storage::consensus_height(&key) { | ||
| Ok(h) => { | ||
| let height = ICSHeight::new(h.revision_number(), h.revision_height()).unwrap(); |
There was a problem hiding this comment.
The error should be upstreamed instead of calling unwrap()
crates/relayer/src/chain/namada.rs
Outdated
Comment on lines
854
to
855
| let port_id = port_id.as_ref().parse().unwrap(); | ||
| let channel_id = channel_id.as_ref().parse().unwrap(); |
There was a problem hiding this comment.
The errors should be upstreamed instead of calling unwrap()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
To transfer tokens between Namada and Cosmos-base chains.
ChainConfigCosmosSdkConfigfor generating Tendermint light clientsNamadaChainasChainEndpointimplementationcrates/relayer/src/chain/namada.rsand files undercrates/relayer/src/chain/namadaPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.