Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow osmosis testnet to use dynamic_gas_price #4248

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Allow osmosis testnet to use dynamic_gas_price #4248

merged 6 commits into from
Nov 18, 2024

Conversation

allthatjazzleo
Copy link
Contributor

@allthatjazzleo allthatjazzleo commented Nov 13, 2024 •
edited by ljoss17
Loading

Closes: #4247

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
    • If guide has been updated, tag GitHub user mircea-c
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

romac
romac reviewed Nov 13, 2024
View reviewed changes
crates/relayer/src/chain/cosmos/eip_base_fee.rs Outdated
@@ -21,7 +21,7 @@ pub async fn query_eip_base_fee(

let chain_name = chain_id.name();

let is_osmosis = chain_name.starts_with("osmosis") || chain_name.starts_with("osmo-test");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should instead fix how the chain id is parsed. I would expect osmos-test-5 to be parsed as

ChainId {
  id: "osmo-test",
  version: 5
}

@ljoss17 @allthatjazzleo What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think so
But not sure will it be a breaking changes to other chain

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we are parsing the chain id correctly, ie. osmo-test-5 is parsed as Chain { id: "osmo-test-5", version: 5 } but the name method is wrong, and does the splitting on - the wrong way, which discards the -test parts of the chain name.

@romac romac changed the title allow osmosis testnet to use dynamic_gas_price Allow osmosis testnet to use dynamic_gas_price Nov 14, 2024
@ljoss17
Copy link
Contributor

ljoss17 commented Nov 14, 2024

Hey @allthatjazzleo thanks for opening this PR!
I updated the method which extracts the chain name to correctly take the name in the case of multiple dashes.
Would you be able to try this and let me know if it works?

@allthatjazzleo
Copy link
Contributor Author

Hey @allthatjazzleo thanks for opening this PR! I updated the method which extracts the chain name to correctly take the name in the case of multiple dashes. Would you be able to try this and let me know if it works?

@ljoss17
It works now with binary built on this branch

@ljoss17 ljoss17 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into informalsystems:master with commit f5b58db Nov 18, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

osmosis testnet cannot use query_eip_base_fee
3 participants
@allthatjazzleo @ljoss17 @romac