Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow osmosis testnet to use dynamic_gas_price #4248

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Allow osmosis testnet to use dynamic_gas_price #4248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c51fd4
allow osmosis testnet to use dynamic_gas_price
allthatjazzleo Nov 13, 2024
11ca926
Fix method to retrieve a chain name
ljoss17 Nov 14, 2024
e194b8f
Merge branch 'master' into fix-osmosis-testnet-eip_base_fee
ljoss17 Nov 14, 2024
21b5a10
Split changelog entry
ljoss17 Nov 15, 2024
7bb7a64
Merge branch 'fix-osmosis-testnet-eip_base_fee' of github.com:allthat…
ljoss17 Nov 15, 2024
33d2496
Apply GitHub suggestions
ljoss17 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .changelog/unreleased/bug-fixes/ibc-relayer/4237-improve-tls-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
- Fix an issue where Hermes would fail to connect to gRPC servers
with an IPv6 address.
([\#4237](https://github.com/informalsystems/hermes/issues/4237))
([\#4237](https://github.com/informalsystems/hermes/issues/4237))
- Fix an issue where osmosis testnet cannot use `dynamic_gas_price` feature.
([\#4247](https://github.com/informalsystems/hermes/issues/4247))
2 changes: 1 addition & 1 deletion crates/relayer/src/chain/cosmos/eip_base_fee.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub async fn query_eip_base_fee(

let chain_name = chain_id.name();

let is_osmosis = chain_name.starts_with("osmosis") || chain_name.starts_with("osmo-test");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should instead fix how the chain id is parsed. I would expect osmos-test-5 to be parsed as

ChainId {
  id: "osmo-test",
  version: 5
}

@ljoss17 @allthatjazzleo What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think so
But not sure will it be a breaking changes to other chain

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, we are parsing the chain id correctly, ie. osmo-test-5 is parsed as Chain { id: "osmo-test-5", version: 5 } but the name method is wrong, and does the splitting on - the wrong way, which discards the -test parts of the chain name.

let is_osmosis = chain_name.starts_with("osmosis") || chain_name.starts_with("osmo");

let url = if is_osmosis {
format!(
Expand Down