Remove min/max length validation for proposal title&desc (#47)

contracts/atom_wars/src/contract.rs

@@ -27,10 +27,6 @@ const CONTRACT_VERSION: &str = env!("CARGO_PKG_VERSION");
 
 pub const MAX_LOCK_ENTRIES: usize = 100;
 
-pub const MIN_PROP_TITLE_LENGTH: usize = 3;
-pub const MAX_PROP_TITLE_LENGTH: usize = 256;
-pub const MAX_PROP_DESC_LENGTH: usize = 10000;
-
 #[entry_point]
 pub fn instantiate(
     deps: DepsMut,
@@ -363,18 +359,15 @@ fn create_proposal(
     let round_id = compute_current_round_id(&env, &constants)?;
     let proposal_id = PROP_ID.load(deps.storage)?;
 
-    let title = sanitize_input_string(title, MIN_PROP_TITLE_LENGTH, MAX_PROP_TITLE_LENGTH)?;
-    let description = sanitize_input_string(description, 0, MAX_PROP_DESC_LENGTH)?;
-
     let proposal = Proposal {
         round_id,
         tranche_id,
         proposal_id,
-        title,
-        description,
         covenant_params,
         power: Uint128::zero(),
         percentage: Uint128::zero(),
+        title: title.trim().to_string(),
+        description: description.trim().to_string(),
     };
 
     PROP_ID.save(deps.storage, &(proposal_id + 1))?;
@@ -955,18 +948,3 @@ fn get_lock_count(deps: Deps, user_address: Addr) -> usize {
         .range(deps.storage, None, None, Order::Ascending)
         .count()
 }
-
-// Trims the input string and validates its minimum and maximum length
-fn sanitize_input_string(input: String, min_length: usize, max_length: usize) -> StdResult<String> {
-    let input = input.trim().to_string();
-    let input_length = input.len();
-
-    if input_length < min_length || input_length > max_length {
-        return Err(StdError::generic_err(format!(
-            "Invalid string length, got {}, expected length to be between {} and {}",
-            input, min_length, max_length
-        )));
-    }
-
-    Ok(input)
-}

contracts/atom_wars/src/testing.rs

@@ -1,7 +1,4 @@
-use crate::contract::{
-    query_whitelist, query_whitelist_admins, MAX_LOCK_ENTRIES, MAX_PROP_DESC_LENGTH,
-    MAX_PROP_TITLE_LENGTH, MIN_PROP_TITLE_LENGTH,
-};
+use crate::contract::{query_whitelist, query_whitelist_admins, MAX_LOCK_ENTRIES};
 use crate::state::Tranche;
 use crate::{
     contract::{
@@ -259,71 +256,6 @@ fn create_proposal_basic_test() {
     assert_eq!(covenant_params_2, proposal.covenant_params);
 }
 
-#[test]
-fn proposal_title_and_desc_validation_test() {
-    let user_address = "addr0000";
-    let user_token = Coin::new(1000, STATOM.to_string());
-
-    let (mut deps, env, info) = (
-        mock_dependencies(),
-        mock_env(),
-        mock_info(user_address, &[user_token.clone()]),
-    );
-    let msg = get_default_instantiate_msg();
-
-    let res = instantiate(deps.as_mut(), env.clone(), info.clone(), msg.clone());
-    assert!(res.is_ok());
-
-    let too_long_title = String::from("too long title ".repeat(20).trim());
-    let too_long_desc = "a".repeat(10001);
-
-    let test_cases = vec![
-        (
-            "proposal title too short",
-            "".to_string(),
-            "proposal description".to_string(),
-            format!(
-                "Invalid string length, got {}, expected length to be between {} and {}",
-                "", MIN_PROP_TITLE_LENGTH, MAX_PROP_TITLE_LENGTH
-            ),
-        ),
-        (
-            "proposal title too long",
-            too_long_title.clone(),
-            "proposal description".to_string(),
-            format!(
-                "Invalid string length, got {}, expected length to be between {} and {}",
-                too_long_title, MIN_PROP_TITLE_LENGTH, MAX_PROP_TITLE_LENGTH
-            ),
-        ),
-        (
-            "proposal description too long",
-            "proposal title".to_string(),
-            too_long_desc.clone(),
-            format!(
-                "Invalid string length, got {}, expected length to be between {} and {}",
-                too_long_desc, 0, MAX_PROP_DESC_LENGTH
-            ),
-        ),
-    ];
-
-    for test_case in test_cases {
-        println!("running test case: {}", test_case.0);
-
-        let msg = ExecuteMsg::CreateProposal {
-            tranche_id: 1,
-            title: test_case.1.to_string(),
-            description: test_case.2.to_string(),
-            covenant_params: get_default_covenant_params(),
-        };
-
-        let res = execute(deps.as_mut(), env.clone(), info.clone(), msg.clone());
-        assert!(res.is_err());
-
-        assert!(res.unwrap_err().to_string().contains(test_case.3.as_str()));
-    }
-}
-
 #[test]
 fn vote_basic_test() {
     let user_address = "addr0000";