Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change whitelist and whitelist admins to be Map<Addr, bool> instead of Vec<Addr> #60

Open
p-offtermatt opened this issue Aug 12, 2024 · 0 comments
Open

Change whitelist and whitelist admins to be Map<Addr, bool> instead of Vec<Addr> #60

p-offtermatt opened this issue Aug 12, 2024 · 0 comments
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.

Comments

@p-offtermatt
Copy link
Member 

          It feels that it would be more performance/gas efficient if we were to store the whitelist addresses as a Map<Addr, bool> instead of Item<Vec<Addr>>. Same goes for whitelist admins. If we decide to do it, it can be done in separate PR.

Originally posted by @dusan-maksimovic in #59 (review)
@p-offtermatt p-offtermatt added the priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-offtermatt