-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom bids duration #165
Custom bids duration #165
Conversation
… max allowed bid duration in config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I added a few comments.
Also, I think it would be good to have a test case to confirm that it is possible to switch ones vote during the round, even when voting for an extended-duration proposal.
could easily be added as part of the test you added I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Description
Closes: #142
This PR introduces a
bid_duration
field on the Proposal to specify for how many rounds the liquidity is requested. If user votes with a lock for a proposal spanning across multiple rounds, it will not be allowed to vote with the same lock in the next rounds until the round in which the liquidity is clawed back from the 'long lasting' proposal. Max bid duration is stored inconfig
and can be updated by the whitelist admins.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
.changelog
make compile
and included content of the artifacts directory into the PRmake schema
and included generated files into the PR