Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom bids duration #165

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Custom bids duration #165

merged 5 commits into from
Oct 30, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

Description

Closes: #142

This PR introduces a bid_duration field on the Proposal to specify for how many rounds the liquidity is requested. If user votes with a lock for a proposal spanning across multiple rounds, it will not be allowed to vote with the same lock in the next rounds until the round in which the liquidity is clawed back from the 'long lasting' proposal. Max bid duration is stored in config and can be updated by the whitelist admins.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I added a few comments.

Also, I think it would be good to have a test case to confirm that it is possible to switch ones vote during the round, even when voting for an extended-duration proposal.

could easily be added as part of the test you added I think

Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dusan-maksimovic dusan-maksimovic merged commit 0388114 into main Oct 30, 2024
5 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/custom-bid-durations branch October 30, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom bid durations
3 participants