Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow short lockups to vote on proposals for longer liquidity deployment #175

Merged

Conversation

dusan-maksimovic
Copy link
Contributor

Description

If users want to vote for proposals with longer liquidity deployment duration, then their lockups must have at least some voting power in round that precedes the round in which the liquidity will be returned. For example, if there is a proposal in round 1 requesting liquidity to be deployed with them for 3 rounds, then users can vote for such proposal only with lockups that are ending in round 4 or later.

Changes had to be made in vote() and lock_tokens() functions because of the "automatic" voting that happens when user locks more tokens, if user already voted for some proposal in current round.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Targeted the correct branch
  • Included the necessary unit tests
  • Added/adjusted the necessary interchain tests
  • Added a changelog entry in .changelog
  • Compiled the contracts by using make compile and included content of the artifacts directory into the PR
  • Regenerated front-end schema by using make schema and included generated files into the PR
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

@dusan-maksimovic dusan-maksimovic merged commit 89e8991 into main Nov 22, 2024
5 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/ensure-lock-duration-for-long-deployments branch November 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants