Add a whitelist #18
Merged
Add a whitelist #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two fields to storage, WHITELIST (which stores covenant params) and WHITELIST_ADMINS (a vector of addresses)
Change covenant_params to assume they hold the right information to filter the whitelist against.
I just assumed some dummy fields for now, e.g. pool_id, channel_id, and name.
WHITELIST_ADMINS are set at instantiation and can remove/add items to the whitelist
Tests for manipulating the whitelist are TODO
The whitelist might be too imperformant; query_top_n_proposals is O(N*M) now, where N is the number of proposals and M is the size of the whitelist.
If we think the core logic, other than performance, is ok, we should write tests for the current imperformant logic, and then adjust any performance issues and verify that the tests are ok.