Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract pausing implementation #51

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

dusan-maksimovic
Copy link
Contributor

  • Add Pause action that can be executed by the Oversight committee to pause the contract.
  • In all other actions check if the contract is paused and return error if it is.
  • Support un-pausing through the governance by migrating to the same code ID (described in readme.md); migrate() function currently only un-pauses the contract.

Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be a query for whether the contract is paused

README.md Outdated Show resolved Hide resolved
contracts/hydro/src/contract.rs Outdated Show resolved Hide resolved
Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Left some comments

contracts/hydro/src/testing.rs Show resolved Hide resolved
Co-authored-by: Philip Offtermatt <[email protected]>
@dusan-maksimovic
Copy link
Contributor Author

There should probably be a query for whether the contract is paused

We already have query for constants, so it would be a bit redundant.

@p-offtermatt
Copy link
Member

You're right, that's good enough

@dusan-maksimovic dusan-maksimovic merged commit 752545f into main Jul 24, 2024
4 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/contract-pausing branch July 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants