Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple tranches #8

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Add support for multiple tranches #8

merged 10 commits into from
Apr 17, 2024

Conversation

p-offtermatt
Copy link
Member

Closes: #6

  • Tranches are created during contract instantiation
  • Changed a few queries and messages to take the tranche id as an input, where it is needed
  • Added a fairly basic test with multiple tranches

Followup questions:

  • Should it be possible to add tranches during execution? (If so, by whom? Permissionless?) Or is fixing the tranches during contact creation good enough (could be right choice if we have easy ways of upgrading the contract)

dusan-maksimovic
dusan-maksimovic reviewed Apr 11, 2024
View reviewed changes
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/testing.rs Show resolved Hide resolved
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/contract.rs Show resolved Hide resolved
contracts/atom_wars/src/testing.rs Outdated Show resolved Hide resolved
dusan-maksimovic
dusan-maksimovic approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@p-offtermatt p-offtermatt merged commit e1da700 into main Apr 17, 2024
3 checks passed
@p-offtermatt p-offtermatt deleted the ph/tranches branch October 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@jtremback jtremback Awaiting requested review from jtremback

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple tranches
2 participants
@p-offtermatt @dusan-maksimovic