-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support of no_std in tendermint
crate
#988
Conversation
Can we set the base to the dependent PR? This would make it easier to review the change. Otherwise it's interleaved with unrelated changes. |
This PR is really just a merge of both #980 and #986 with an additional commit f07d0c0. So you can just look at that in the meanwhile. After the other PRs we can update this branch again for a cleaner diff. |
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
========================================
- Coverage 66.1% 66.0% -0.1%
========================================
Files 209 209
Lines 20764 20760 -4
========================================
- Hits 13726 13720 -6
- Misses 7038 7040 +2
Continue to review full report at Codecov.
|
Thanks for the clarification, let's set it to Draft to indicate that crucial prerequisites are not in place yet. |
5f11d5d
to
7569e1b
Compare
std
import in main tendermint
cratetendermint
crate
* Bump version to v0.23.1 Signed-off-by: Thane Thomson <[email protected]> * Update changelog for v0.23.1 release Signed-off-by: Thane Thomson <[email protected]> * Build changelog Signed-off-by: Thane Thomson <[email protected]>
735aa0b
to
89ceb7d
Compare
The most recent release of ed25519 API deprecates the standalone SIGNATURE_LENGTH constant in favor of the Signature::BYTE_SIZE associated item. Also, the Signature::new constructor is deprecated in favor of Signature::from_bytes. Update the code to not trigger the deprecation lints. In turn, deprecate what was formerly the reexport of that constant in the tendermint API.
This is now fixed by #1087. |
Part of informalsystems/hermes#1158.
This PR builds on #980 and #986. Either the two PRs can be merged separately first, or we can merge them together here in one go.
.changelog/