Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support of no_std in tendermint crate #988

Closed
wants to merge 8 commits into from

Conversation

soareschen
Copy link
Contributor

Part of informalsystems/hermes#1158.

This PR builds on #980 and #986. Either the two PRs can be merged separately first, or we can merge them together here in one go.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@xla
Copy link
Contributor

xla commented Sep 28, 2021

Can we set the base to the dependent PR? This would make it easier to review the change. Otherwise it's interleaved with unrelated changes.

@soareschen
Copy link
Contributor Author

Can we set the base to the dependent PR? This would make it easier to review the change. Otherwise it's interleaved with unrelated changes.

This PR is really just a merge of both #980 and #986 with an additional commit f07d0c0. So you can just look at that in the meanwhile. After the other PRs we can update this branch again for a cleaner diff.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #988 (27a3ed3) into master (9690eca) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #988     +/-   ##
========================================
- Coverage    66.1%   66.0%   -0.1%     
========================================
  Files         209     209             
  Lines       20764   20760      -4     
========================================
- Hits        13726   13720      -6     
- Misses       7038    7040      +2     
Impacted Files Coverage Δ
config/src/config.rs 55.0% <ø> (-1.5%) ⬇️
light-client/src/lib.rs 100.0% <ø> (ø)
proto/src/lib.rs 100.0% <ø> (ø)
tendermint/src/lib.rs 100.0% <ø> (ø)
tendermint/src/signature.rs 55.0% <ø> (+0.5%) ⬆️
tendermint/src/proposal.rs 90.4% <100.0%> (-0.3%) ⬇️
tendermint/src/test.rs 100.0% <100.0%> (ø)
tendermint/src/vote.rs 76.6% <100.0%> (+0.3%) ⬆️
tendermint/src/vote/sign_vote.rs 96.5% <100.0%> (ø)
testgen/src/vote.rs 84.8% <100.0%> (+0.8%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9690eca...27a3ed3. Read the comment docs.

@xla
Copy link
Contributor

xla commented Sep 29, 2021

This PR is really just a merge of both #980 and #986 with an additional commit f07d0c0. So you can just look at that in the meanwhile. After the other PRs we can update this branch again for a cleaner diff.

Thanks for the clarification, let's set it to Draft to indicate that crucial prerequisites are not in place yet.

@soareschen soareschen marked this pull request as draft September 29, 2021 07:48
@soareschen soareschen force-pushed the soares/activate-no-std branch 2 times, most recently from 5f11d5d to 7569e1b Compare September 30, 2021 14:23
@soareschen soareschen changed the title Disable std import in main tendermint crate Full support of no_std in tendermint crate Oct 6, 2021
@soareschen soareschen added the no_std no_std compatibility label Oct 7, 2021
thanethomson and others added 2 commits November 15, 2021 18:39
* Bump version to v0.23.1

Signed-off-by: Thane Thomson <[email protected]>

* Update changelog for v0.23.1 release

Signed-off-by: Thane Thomson <[email protected]>

* Build changelog

Signed-off-by: Thane Thomson <[email protected]>
mzabaluev and others added 6 commits November 23, 2021 12:21
The most recent release of ed25519 API deprecates the standalone
SIGNATURE_LENGTH constant in favor of the Signature::BYTE_SIZE
associated item. Also, the Signature::new constructor is deprecated
in favor of Signature::from_bytes.
Update the code to not trigger the deprecation lints.

In turn, deprecate what was formerly the reexport of
that constant in the tendermint API.
@soareschen
Copy link
Contributor Author

This is now fixed by #1087.

@soareschen soareschen closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_std no_std compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants