Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(legend): Ajustements de style #40

Merged
merged 10 commits into from
Sep 25, 2023
Merged

style(legend): Ajustements de style #40

merged 10 commits into from
Sep 25, 2023

Conversation

mneige
Copy link
Contributor

@mneige mneige commented Jun 7, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Le dialogue de la légende n'a pas de barre de défilement et en mode menu activé elle s'affiche dans le menu
Il n'est pas clair pour l'utilisateur comment ajuster la hauteur et longueur de la fenêtre de dialog

What is the new behavior?
Le dialogue s'affiche dans la carte et a une barre de défilement
Le code est nettoyé, des commentaires explicatifs ajoutés et une documentation wiki

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mneige mneige requested a review from alecarn June 7, 2023 13:17
@mneige mneige self-assigned this Jun 7, 2023
@mneige mneige marked this pull request as draft June 7, 2023 13:19
@mneige mneige added this to the Ready for review milestone Jun 16, 2023
@mneige mneige added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 16, 2023
@mneige mneige marked this pull request as ready for review June 16, 2023 20:00
@mneige mneige removed this from the Ready for review milestone Jun 16, 2023
src/assets/legends/legend.css Outdated Show resolved Hide resolved
src/assets/legends/legend.css Outdated Show resolved Hide resolved
src/assets/legends/legend/legende.html Outdated Show resolved Hide resolved
src/assets/legends/legend/legende.html Outdated Show resolved Hide resolved
src/assets/legends/legend/legende.html Outdated Show resolved Hide resolved
src/wiki Outdated Show resolved Hide resolved
src/app/pages/portal/portal.component.scss Show resolved Hide resolved
src/wiki Outdated Show resolved Hide resolved
@alecarn alecarn merged commit 5aa9d58 into master Sep 25, 2023
4 checks passed
@alecarn alecarn deleted the legendDialog branch September 25, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants