From 80f789a86bc0e4624ce1eaa14614aca196dd0456 Mon Sep 17 00:00:00 2001 From: Emma Foley Date: Wed, 14 Aug 2024 13:51:27 +0100 Subject: [PATCH] Use ignore_errors in plays for test_logging The logging plugins we use need all the tests to run in order to report properly. Adding ignore_errors to the plays that run the tests allows all the tests to run even when one fails. Also added verbosity to the ansible config to get more info about the failing tests --- ci/ansible.cfg | 3 +++ ci/logging_tests_computes.yml | 5 +++-- ci/logging_tests_local.yml | 24 +++++++++--------------- 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/ci/ansible.cfg b/ci/ansible.cfg index 3c9d90c0..fb76f2b9 100644 --- a/ci/ansible.cfg +++ b/ci/ansible.cfg @@ -3,3 +3,6 @@ callbacks_enabled = custom_logger callback_plugins = ../callback_plugins # additional paths to search for roles roles_path = ../roles:/usr/share/ansible/roles:/etc/ansible/roles:~/.ansible/roles:../../ci-framework/roles + +# temp update to get more information from the playbooks running functional tests +verbosity = 5 diff --git a/ci/logging_tests_computes.yml b/ci/logging_tests_computes.yml index 723802c0..94f1d8b4 100644 --- a/ci/logging_tests_computes.yml +++ b/ci/logging_tests_computes.yml @@ -1,3 +1,4 @@ +--- - name: Prepare Logging Tests hosts: computes gather_facts: false @@ -9,6 +10,7 @@ - name: "Verify ctlplane logging containers and files" hosts: computes gather_facts: no + ignore_errors: true vars: container_test_id: "RHOSO-12753" container_list: @@ -19,7 +21,6 @@ file_test_id: "RHOSO-12754" file_list: - /etc/rsyslog.d/10-telemetry.conf - tasks: - name: "Run file and container tests" ansible.builtin.import_role: @@ -29,12 +30,12 @@ - name: "Verify logging journalctl identifiers" hosts: computes gather_facts: no + ignore_errors: true vars: identifiers_test_id: "RHOSO-12681" identifiers_list: - ceilometer_agent_compute - nova_compute - tasks: - name: "Verify journalctl logging identifiers" ansible.builtin.import_role: diff --git a/ci/logging_tests_local.yml b/ci/logging_tests_local.yml index a2dee02e..d20f45b5 100644 --- a/ci/logging_tests_local.yml +++ b/ci/logging_tests_local.yml @@ -1,6 +1,8 @@ +--- - name: Prepare Logging Tests hosts: controller gather_facts: false + ignore_errors: true vars: id_rsa_path: "{{ playbook_dir }}/id_rsa.ctlplane" environment: @@ -32,6 +34,7 @@ - name: "Verify logging projects, endpoints, credentials, nodes, pods, services, manifests and subscriptions" hosts: controller gather_facts: no + ignore_errors: true vars: proj_test_id: "RHOSO-12668" proj_list: @@ -39,8 +42,6 @@ - openshift - openstack-operators - openshift-logging - - endpoint_test_id: "RHOSO-12682" endpoint_list: - [nova,compute,public] @@ -60,7 +61,6 @@ - [neutron,network,public] - [neutron,network,internal] - cred_test_id: "RHOSO-12670" cred_list: - alertingrules.loki.grafana.com @@ -68,14 +68,12 @@ - recordingrules.loki.grafana.com - rulerconfigs.loki.grafana.com - node_test_id: "RHOSO-12671" node_list: - edpm-compute-0 - edpm-compute-1 - crc - pod_test_id: "RHOS0-12672" pod_status_str: "Running" pod_nspace: openstack-operators @@ -83,7 +81,6 @@ - telemetry-operator-controller-manager - dataplane-operator-controller-manager - service_test_id: "RHOSO-12675" service_nspace: openshift-logging service_list: @@ -104,36 +101,30 @@ - logging-loki-query-frontend-http - logging-view-plugin - openstack-logging - - manifest_test_id: "RHOSO-12677" manifest_list: - "loki-operator 2" - "loki-helm-operator 1" - - subscription_test_id: "RHOSO-12678" subscription_nspace: openshift-operators-redhat subscription_list: - loki-operator - tasks: - name: "Run logging project, endpoint, credential, node, pod, service, manifest and subscription tests" ansible.builtin.import_role: name: common - - name: "Verify logging pods are running in openstack" hosts: controller gather_facts: no + ignore_errors: true vars: pod_test_id: "RHOSO-12752" pod_status_str: "Running" pod_nspace: openstack pod_list: - openstackclient - tasks: - name: "Verify Running Pods" ansible.builtin.import_role: @@ -143,6 +134,7 @@ - name: "Verify logging pods are running in openshift-operators-redhat" hosts: controller gather_facts: no + ignore_errors: true vars: pod_test_id: "RHOSO-12673" pod_status_str: "Running" @@ -159,6 +151,7 @@ - name: "Verify logging pods are running in openshift-logging" hosts: controller gather_facts: no + ignore_errors: true vars: pod_test_id: "RHOSO-12676" pod_status_str: "Running" @@ -185,6 +178,7 @@ - name: "Verify logging pods are running in minio-dev" hosts: controller gather_facts: no + ignore_errors: true vars: pod_test_id: "RHOSO-12674" pod_status_str: "Running" @@ -201,6 +195,7 @@ - name: "Verify logging pods have complete status in openstack" hosts: controller gather_facts: no + ignore_errors: true vars: pod_test_id: "RHOSO-12679" pod_nspace: openstack @@ -223,7 +218,6 @@ - ssh-known-hosts-edpm-deployment-logging - telemetry-edpm-deployment-logging - validate-network-edpm-deployment-logging - tasks: - name: "Run pods completed tests" ansible.builtin.import_role: @@ -233,6 +227,7 @@ - name: "Verify logging services are running in openstack" hosts: controller gather_facts: no + ignore_errors: true vars: service_test_id: "RHOSO-12749" service_nspace: openstack @@ -241,7 +236,6 @@ - nova-metadata-internal - nova-novncproxy-cell1-public - nova-public - tasks: - name: "Run Services tests" ansible.builtin.import_role: