Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using flake8-isort instead of flake8-import-order #427

Open
sbellem opened this issue Mar 5, 2020 · 0 comments
Open

Consider using flake8-isort instead of flake8-import-order #427

sbellem opened this issue Mar 5, 2020 · 0 comments
Assignees
Labels
code quality Coding conventions, etc maintenance better way to write existing code, better tools/packages which can simplify things priority:low

Comments

@sbellem
Copy link
Collaborator

sbellem commented Mar 5, 2020

Problem: It appears that setting up flake8 with PyCharm is not so easy and perhaps the same goes for some other editors. Additionally flake8-import-order, even when flake8 is properly integrated withing an editor, will not fix the import orders but simply flag them as being not ok.

Solution: Automate the ordering of the imports with a tool. Using isort can automate the task of sorting the import order, in a similar way than black formats the code and flake8-isort can detect ordering "errors". See psf/black#333 for black/isort interop.

@sbellem sbellem added code quality Coding conventions, etc maintenance better way to write existing code, better tools/packages which can simplify things priority:low labels Mar 5, 2020
@sbellem sbellem self-assigned this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Coding conventions, etc maintenance better way to write existing code, better tools/packages which can simplify things priority:low
Projects
None yet
Development

No branches or pull requests

1 participant