From 6062b278aff348c9962b505b8c5555c9c4bdfb1e Mon Sep 17 00:00:00 2001
From: beer-1 <147697694+beer-1@users.noreply.github.com>
Date: Mon, 25 Mar 2024 12:06:04 +0900
Subject: [PATCH] add tests

---
 x/ophost/keeper/output.go      |  4 ++--
 x/ophost/keeper/output_test.go | 30 ++++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/x/ophost/keeper/output.go b/x/ophost/keeper/output.go
index 75d99f6e..50db2a6c 100644
--- a/x/ophost/keeper/output.go
+++ b/x/ophost/keeper/output.go
@@ -26,9 +26,9 @@ func (k Keeper) DeleteOutputProposal(ctx context.Context, bridgeId, outputIndex
 	if err != nil {
 		return err
 	}
-	if isFinal, err := k.isFinalized(ctx, bridgeId, output); err != nil {
+	if isFinalized, err := k.isFinalized(ctx, bridgeId, output); err != nil {
 		return err
-	} else if isFinal {
+	} else if isFinalized {
 		return types.ErrAlreadyFinalized
 	}
 
diff --git a/x/ophost/keeper/output_test.go b/x/ophost/keeper/output_test.go
index 762c4d45..11d3cdd1 100644
--- a/x/ophost/keeper/output_test.go
+++ b/x/ophost/keeper/output_test.go
@@ -130,3 +130,33 @@ func Test_NextOutputIndex(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, uint64(101), index)
 }
+
+func Test_DeleteOutputProposal(t *testing.T) {
+	ctx, input := createDefaultTestInput(t)
+
+	output := types.Output{
+		OutputRoot:    []byte{1, 2, 3},
+		L1BlockTime:   ctx.BlockTime(),
+		L2BlockNumber: 100,
+	}
+	err := input.OPHostKeeper.SetOutputProposal(ctx, 1, 1, output)
+	require.NoError(t, err)
+
+	err = input.OPHostKeeper.SetBridgeConfig(ctx, 1, types.BridgeConfig{
+		Challenger:          "",
+		Proposer:            "",
+		SubmissionInterval:  time.Second * 10,
+		FinalizationPeriod:  time.Second * 10,
+		SubmissionStartTime: ctx.BlockTime(),
+		Metadata:            nil,
+	})
+	require.NoError(t, err)
+
+	// delete should fail due to already finalized error
+	err = input.OPHostKeeper.DeleteOutputProposal(ctx.WithBlockTime(ctx.BlockTime().Add(time.Second*11)), 1, 1)
+	require.ErrorIs(t, err, types.ErrAlreadyFinalized)
+
+	// delete should success
+	err = input.OPHostKeeper.DeleteOutputProposal(ctx.WithBlockTime(ctx.BlockTime().Add(time.Second*9)), 1, 1)
+	require.NoError(t, err)
+}