Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to Ky for http request #105

Open
RomainLanz opened this issue Jan 21, 2025 · 1 comment
Open

Migrating to Ky for http request #105

RomainLanz opened this issue Jan 21, 2025 · 1 comment

Comments

@RomainLanz
Copy link

Hey there! 👋🏻

I saw that your project is using Axios for HTTP requests, and I thought Ky might be a good alternative to consider. Ky is a lightweight HTTP client built on the modern Fetch API, whereas Axios still relies on the older XMLHttpRequest.

It seems like this could be a small change since Axios is only used in one place, but I could be wrong. It all depends on how you're using it and any features I might not be aware of.

If you're interested, I’d be happy to help with the change and submit a PR.
@joon9823
Copy link
Collaborator

great suggestion!

would love to review the PR you make

@suhaotian suhaotian mentioned this issue Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RomainLanz @joon9823