Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: evm-nft indexer and bug fixes #55

Merged
merged 24 commits into from
Aug 6, 2024
Merged

feature: evm-nft indexer and bug fixes #55

merged 24 commits into from
Aug 6, 2024

Conversation

Vritra4
Copy link
Collaborator

@Vritra4 Vritra4 commented Aug 6, 2024

Here are some features and fixes:

(evm-nft) feature: implement
(store) fix: ignore cache delete error and put assertion
(*-nft) fix: queries to not use CollectionFilteredPaginate() which is occuring full scan
lint and remove unnecessary codes

NOTE: evm-nft depends on stoneevm-16-4 versioned minievm

@Vritra4 Vritra4 requested review from SeUkKim and joon9823 August 6, 2024 06:56
@Vritra4 Vritra4 self-assigned this Aug 6, 2024
@Vritra4 Vritra4 changed the title Evm nft feature: evm-nft indexer and bug fixes Aug 6, 2024
joon9823
joon9823 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@joon9823 joon9823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit fc557a1 into main Aug 6, 2024
4 checks passed
@Vritra4 Vritra4 deleted the evm-nft branch August 6, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joon9823 joon9823 joon9823 approved these changes

@SeUkKim SeUkKim Awaiting requested review from SeUkKim

Assignees

@Vritra4 Vritra4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vritra4 @joon9823