Skip to content

Commit

Permalink
fix proto-lint and add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Vritra4 committed Jul 12, 2024
1 parent a59fe85 commit f1394b8
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ proto-format:
@$(protoImage) find ./ -name "*.proto" -exec clang-format -i {} \;

proto-lint:
@$(protoImage) buf lint --error-format=json
@$(protoImage) buf lint --error-format=json ./proto

proto-check-breaking:
@$(protoImage) buf breaking --against $(HTTPS_GIT)#branch=main
Expand Down
8 changes: 4 additions & 4 deletions proto/minievm/evm/v1/auth.proto
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ message ContractAccount {
cosmos.auth.v1beta1.BaseAccount base_account = 1 [(gogoproto.embed) = true];
}

// ShorthandAccount defines an account of shorthand address
// ShorthandAccount defines an account of shorthand address
// which is used to store the original long address (32bytes).
//
//
// Also it is used to check the existence of the account before
// creating a new account.
message ShorthandAccount {
option (amino.name) = "evm/ShorthandAccount";
option (gogoproto.goproto_getters) = false;

cosmos.auth.v1beta1.BaseAccount base_account = 1 [(gogoproto.embed) = true];
string original_address = 2;
cosmos.auth.v1beta1.BaseAccount base_account = 1 [(gogoproto.embed) = true];
string original_address = 2;
}
2 changes: 2 additions & 0 deletions proto/minievm/evm/v1/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ service Query {
option (google.api.http).get = "/minievm/evm/v1/states/{contract_addr}/{key}";
}

// ContractAddrByDenom gets the contract address by denom.
rpc ContractAddrByDenom(QueryContractAddrByDenomRequest) returns (QueryContractAddrByDenomResponse) {
option (google.api.http).get = "/minievm/evm/v1/contracts/by_denom";
}

// Denom gets the denom of the given contract address.
rpc Denom(QueryDenomRequest) returns (QueryDenomResponse) {
option (google.api.http).get = "/minievm/evm/v1/denoms/{contract_addr}";
}
Expand Down
2 changes: 1 addition & 1 deletion proto/minievm/evm/v1/tx.proto
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ message MsgCreate2 {

// Code is hex encoded raw contract bytes code.
string code = 2;

// Salt is a random value to distinguish contract creation.
uint64 salt = 3;
}
Expand Down
4 changes: 4 additions & 0 deletions x/evm/types/query.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f1394b8

Please sign in to comment.