Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to guarantee ack & timeout to be sccuess #23

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

beer-1
Copy link
Collaborator

@beer-1 beer-1 commented Jun 14, 2024

No description provided.

@beer-1 beer-1 requested a review from sh-cha June 14, 2024 03:47
@beer-1 beer-1 self-assigned this Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (1d6b989) to head (7b05c26).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   31.79%   31.81%   +0.02%     
==========================================
  Files          68       68              
  Lines        8291     8325      +34     
==========================================
+ Hits         2636     2649      +13     
- Misses       5301     5322      +21     
  Partials      354      354              
Files Coverage Δ
app/ibc-hooks/ack.go 50.00% <40.00%> (+0.84%) ⬆️
app/ibc-hooks/timeout.go 30.26% <20.00%> (-1.95%) ⬇️

@beer-1 beer-1 merged commit 5937f1a into main Jun 14, 2024
5 of 6 checks passed
@beer-1 beer-1 deleted the fix/guarantee-ack-timeout-success branch June 14, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant