Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all dummy return data to all precompiles to bypass code size check #25

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

beer-1
Copy link
Collaborator

@beer-1 beer-1 commented Jun 20, 2024

we customized go-ethereum to by-pass code existence check, but we found other way to by-pass it.

Rollback go-ethereum

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 31.82%. Comparing base (d5790e0) to head (f56a088).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   31.81%   31.82%           
=======================================
  Files          68       68           
  Lines        8325     8343   +18     
=======================================
+ Hits         2649     2655    +6     
- Misses       5322     5330    +8     
- Partials      354      358    +4     
Files Coverage Δ
x/evm/contracts/counter/Counter.go 0.00% <ø> (ø)
x/evm/contracts/custom_erc20/CustomERC20.go 0.00% <ø> (ø)
x/evm/contracts/erc20/ERC20.go 0.00% <ø> (ø)
x/evm/contracts/erc20_factory/ERC20Factory.go 0.00% <ø> (ø)
x/evm/contracts/erc20_registry/ERC20Registry.go 0.00% <ø> (ø)
x/evm/contracts/i_cosmos/ICosmos.go 0.00% <ø> (ø)
x/evm/contracts/i_erc20_registry/IERC20Registry.go 0.00% <ø> (ø)
x/evm/precompiles/cosmos/contract.go 48.61% <50.00%> (+0.04%) ⬆️
x/evm/precompiles/erc20_registry/contract.go 47.82% <25.00%> (-3.43%) ⬇️

@beer-1 beer-1 merged commit f5037a4 into main Jun 20, 2024
6 checks passed
@beer-1 beer-1 deleted the fix/precompile-return-data branch June 20, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant