Merge pull request #14 from initia-labs/fix/oracle-view

fix: compiler to report error after extended check

crates/compiler/src/built_package.rs

@@ -84,6 +84,7 @@ impl BuiltPackage {
 
         // Run extended checks as well derive runtime metadata
         let model = &model_opt.expect("move model");
+        let runtime_metadata = extended_checks::run_extended_checks(model);
         if model.diag_count(Severity::Warning) > 0 {
             let mut error_writer = StandardStream::stderr(ColorChoice::Auto);
             model.report_diag(&mut error_writer, Severity::Warning);
@@ -92,7 +93,6 @@ impl BuiltPackage {
             }
         }
 
-        let runtime_metadata = extended_checks::run_extended_checks(model);
         let compiled_pkg_path = package
             .compiled_package_info
             .build_flags

precompile/modules/minitia_stdlib/sources/oracle.move

@@ -2,8 +2,8 @@ module minitia_std::oracle {
     use minitia_std::string::{Self, String};
 
     #[view]
-    public fun get_price(pair_id: &String): (u256, u64, u64) {
-        get_price_internal(*string::bytes(pair_id))
+    public fun get_price(pair_id: String): (u256, u64, u64) {
+        get_price_internal(*string::bytes(&pair_id))
     }
 
     native fun get_price_internal(pair_id: vector<u8>): (u256, u64, u64);
@@ -33,12 +33,12 @@ module minitia_std::oracle {
         set_price(&btc_usd_pair_id, btc_price, btc_updated_at, btc_decimals);
         set_price(&eth_usd_pair_id, eth_price, eth_updated_at, eth_decimals);
 
-        let (price, updated_at, decimals) = get_price(&btc_usd_pair_id);
+        let (price, updated_at, decimals) = get_price(btc_usd_pair_id);
         assert!(btc_price == price, 0);
         assert!(btc_updated_at == updated_at, 0);
         assert!(btc_decimals == decimals, 0);
 
-        let (price, updated_at, decimals) = get_price(&eth_usd_pair_id);
+        let (price, updated_at, decimals) = get_price(eth_usd_pair_id);
         assert!(eth_price == price, 0);
         assert!(eth_updated_at == updated_at, 0);
         assert!(eth_decimals == decimals, 0);