impv: better weave loading interface

Author: traviolus

models/weaveinit/run_l1_node.go

@@ -619,5 +619,8 @@ func (m *InitializingAppLoading) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 }
 
 func (m *InitializingAppLoading) View() string {
-	return m.Loading.View(m.state.weave.PreviousResponse)
+	if m.Completing {
+		return m.state.weave.PreviousResponse
+	}
+	return m.state.weave.PreviousResponse + m.Loading.View()
 }

utils/loading.go

@@ -69,16 +69,16 @@ func (m Loading) Update(msg tea.Msg) (Loading, tea.Cmd) {
 	}
 }
 
-func (m Loading) View(previousResponse string) string {
+func (m Loading) View() string {
 	if m.frame >= len(m.Spinner.Frames) {
 		return "(error)"
 	}
 	spinner := m.Style.Render(m.Spinner.Frames[m.frame])
 
 	if m.Completing {
-		return previousResponse
+		return ""
 	}
-	str := fmt.Sprintf("%s%s%s\n", previousResponse, spinner, m.Text)
+	str := fmt.Sprintf("%s%s\n", spinner, m.Text)
 	return str
 }