Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: review round 2 #35

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: review round 2 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"dependencies": {
"@headlessui/react": "2.1.6",
"@hookform/resolvers": "3.9.1",
"@inkonchain/ink-kit": "0.7.2",
"@inkonchain/ink-kit": "0.8.0",
"@next/third-parties": "15.1.6",
"@octokit/auth-app": "7.1.3",
"@octokit/rest": "21.0.2",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/app/[locale]/_components/AboutContent/_components/PartnerCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const PartnerCard: React.FC<PartnerCardProps> = ({
className="flex flex-col flex-1"
asChild
>
<Link className="flex-1" href={url}>
<Link className="flex-1" href={url} target="_blank">
<div className="flex items-center justify-center h-[244px]">
{image}
</div>
Expand Down
10 changes: 7 additions & 3 deletions src/app/[locale]/_components/ConnectWalletButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ interface ConnectWalletButtonProps {
className?: string;
connectLabel?: string;
shrinkOnMobile?: boolean;
noIcon?: boolean;
size?: "md" | "lg";
}

Expand All @@ -26,6 +27,7 @@ export const ConnectWalletButton: React.FC<ConnectWalletButtonProps> = ({
connectLabel = "Connect",
shrinkOnMobile = false,
size = "md",
noIcon = false,
}) => {
return (
<ConnectButton.Custom>
Expand Down Expand Up @@ -59,9 +61,11 @@ export const ConnectWalletButton: React.FC<ConnectWalletButtonProps> = ({
size={size}
variant="primary"
>
<div className={shrinkOnMobile ? "sm:hidden" : ""}>
<InkIcon.Wallet className="size-6" enforce="inherit" />
</div>
{!noIcon && (
<div className={shrinkOnMobile ? "sm:hidden" : ""}>
<InkIcon.Wallet className="size-6" enforce="inherit" />
</div>
)}
<div className={shrinkOnMobile ? "hidden sm:block" : ""}>
{connectLabel}
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/app/[locale]/new/_components/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export const PageHeader = ({
>
<ColoredText
className={classNames({
"text-4xl sm:text-6xl": size === "default",
"text-5xl sm:text-6xl md:text-[110px] lg:text-[120px] sm:leading-[95%] xl:text-[130px]":
"font-medium text-4xl sm:text-6xl": size === "default",
"font-medium text-5xl sm:text-6xl md:text-[110px] lg:text-[120px] sm:leading-[95%] xl:text-[130px]":
size === "home",
})}
variant="purple"
Expand Down
165 changes: 79 additions & 86 deletions src/app/[locale]/new/about/_components/AboutContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,92 +31,85 @@ export function AboutContent() {
imageLocation="left"
>
<CardContent.TitleAndDescription title="DeFi expectations" />
<CardContent.CardInfo>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/1s-block-times.svg"
width={24}
height={24}
alt="Sub-second block times"
/>
}
title="Sub-second block times"
description="1s block times Day 1, sub-second blocks coming soon."
/>
</Card>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/Smol-Gas.svg"
width={24}
height={24}
alt="smol gas"
/>
}
title="Smol Gas"
description="Ape more, pay less."
/>
</Card>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/Security.svg"
width={24}
height={24}
alt="security"
/>
}
title="Security"
description="Sequencer-level security to protect users from malicious intents and exploits."
/>
</Card>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/Interoperability.svg"
width={24}
height={24}
alt="interoperability"
/>
}
title="Interoperability"
description="A commitment to the seamless flow of capital across the Superchain and beyond."
/>
</Card>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/Unleashed-by-Kraken.svg"
width={24}
height={24}
alt="Unleashed by kraken"
/>
}
title="Unleashed by Kraken"
description="Ink will leverage Kraken's security and crypto expertise to support builders and users alike as they move towards independent financial sovereignty."
/>
</Card>
<Card variant="secondary">
<CardContent.Tiny
icon={
<Image
src="/icons/ethereum-eth-logo.svg"
width={24}
height={24}
alt="Scaling Ethereum"
/>
}
title="Scaling Ethereum"
description="Ink is dedicated to scaling Ethereum with a powerful L2 that enhances performance and accessibility."
/>
</Card>
</CardContent.CardInfo>
<CardContent.CardInfos>
<CardContent.CardInfo
icon={
<Image
src="/icons/1s-block-times.svg"
width={24}
height={24}
alt="Sub-second block times"
/>
}
title="Sub-second block times"
description="1s block times Day 1, sub-second blocks coming soon."
/>

<CardContent.CardInfo
icon={
<Image
src="/icons/Smol-Gas.svg"
width={24}
height={24}
alt="smol gas"
/>
}
title="Smol Gas"
description="Ape more, pay less."
/>

<CardContent.CardInfo
icon={
<Image
src="/icons/Security.svg"
width={24}
height={24}
alt="security"
/>
}
title="Security"
description="Sequencer-level security to protect users from malicious intents and exploits."
/>

<CardContent.CardInfo
icon={
<Image
src="/icons/Interoperability.svg"
width={24}
height={24}
alt="interoperability"
/>
}
title="Interoperability"
description="A commitment to the seamless flow of capital across the Superchain and beyond."
/>

<CardContent.CardInfo
icon={
<Image
src="/icons/Unleashed-by-Kraken.svg"
width={24}
height={24}
alt="Unleashed by kraken"
/>
}
title="Unleashed by Kraken"
description="Ink will leverage Kraken's security and crypto expertise to support builders and users alike as they move towards independent financial sovereignty."
/>

<CardContent.CardInfo
icon={
<Image
src="/icons/ethereum-eth-logo.svg"
width={24}
height={24}
alt="Scaling Ethereum"
/>
}
title="Scaling Ethereum"
description="Ink is dedicated to scaling Ethereum with a powerful L2 that enhances performance and accessibility."
/>
</CardContent.CardInfos>
</Card>

<div className="flex flex-col gap-6">
Expand Down
2 changes: 1 addition & 1 deletion src/app/[locale]/new/apps/_components/AppsCategoryFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const AppsCategoryFilter = ({
return (
<ScrollWithGradient className="flex overflow-x-scroll flex-1 w-full sm:w-auto no-scrollbar">
<SegmentedControl
variant="primary"
variant="tag"
variableTabWidth
options={options}
onOptionChange={(option) =>
Expand Down
2 changes: 1 addition & 1 deletion src/app/[locale]/new/apps/_components/AppsGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function AppCard({
</div>
)}
</div>
<div className="flex flex-col gap-4 flex-1">
<div className="flex flex-col gap-4 flex-1 w-full">
<div className="ink:text-h5">{app.name}</div>
<div className="flex-1 ink:text-body-3-regular ink:text-text-muted">
{app.description}
Expand Down
2 changes: 1 addition & 1 deletion src/app/[locale]/new/verify/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function VerifyPage() {
description={t("description")}
cta={
<div className="relative w-full">
<ConnectWalletButton connectLabel={t("cta")} />
<ConnectWalletButton connectLabel={t("cta")} size="lg" />
</div>
}
/>
Expand Down
4 changes: 2 additions & 2 deletions src/app/[locale]/verify/_components/Verifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ const DesktopVerificationsTable = () => {
Available
</span>
) : (
<ConnectWalletButton size="md" />
<ConnectWalletButton size="md" noIcon />
)}
</div>
</td>
Expand Down Expand Up @@ -232,7 +232,7 @@ const MobileVerificationsTable = () => {
Available
</span>
) : (
<ConnectWalletButton size="md" />
<ConnectWalletButton size="md" noIcon />
)}
</div>
</div>
Expand Down
Loading