Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defective codes at the latest commit #7

Open
azulika opened this issue Jan 24, 2023 · 1 comment · May be fixed by #8
Open

defective codes at the latest commit #7

azulika opened this issue Jan 24, 2023 · 1 comment · May be fixed by #8

Comments

@azulika
Copy link

azulika commented Jan 24, 2023

f6d9de5 seems to have several possible and definite bugs. First, train_ms.py's

_, _, _, epoch_str = utils.load_old_checkpoint(ckptD, net_d, optim_d)

part has been modified to:

_, _, _, epoch_str = utils.load_checkpoint(ckptG, net_g, optim_g, is_old=True)

, which is clearly incorrect since it's loading ckptG instead of ckptD, as well as other G-related arguments.
Second, this one is possibly just me, but single-speaker training train.py doesn't seem to work. This may be due to the checkpoint-loading defect, which is present in both train.py and train_ms.py; I only tried to train the model with the current code(unfixed the bugs aforementioned), so I don't know exactly why it didn't work.

@wind4000
Copy link
Contributor

wind4000 commented Feb 5, 2023

Sorry for the mistake i've made. I didn't check it out when making changes that i copied this line twice.
Except that, checkpoint-loading function seems no problem as i've checked it on colab before.

@wind4000 wind4000 linked a pull request Feb 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants