Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find기능 개편 #310

Closed
Belnut opened this issue Jul 31, 2021 · 2 comments · Fixed by #324
Closed

find기능 개편 #310

Belnut opened this issue Jul 31, 2021 · 2 comments · Fixed by #324
Assignees
@Belnut

Comments

@Belnut
Copy link
Collaborator

Belnut commented Jul 31, 2021

현재 home 화면의 내팀 목록에 end 외에 revoke, timeout된 팀도 표기됩니다.

  1. ui를 수정하거나
  2. find 쿼리를 개편하거나
  3. service 의 find 로직을 추가해야 합니다.
@Belnut Belnut changed the title find 쿼리 개편 find기능 개편 Jul 31, 2021
@Belnut Belnut self-assigned this Aug 26, 2021
@Belnut
Copy link
Collaborator Author

Belnut commented Aug 26, 2021

지금은 임시적으로 find jpql를 수정할 예정입니다.
이후 querydsl 등을 적용하는 리펙토링 작업이 필요할 듯 합니다.

@Belnut
Copy link
Collaborator Author

Belnut commented Aug 26, 2021

우선 Teamstatus 상태에 따른 조회 쿼리를 일부 수정하는 것으로 이슈를 닫습니다.
issue #323 이 이를 물려받습니다.

@Belnut Belnut closed this as completed Aug 26, 2021
@Belnut Belnut reopened this Aug 26, 2021
Belnut added a commit to Belnut/swlabs-helper that referenced this issue Aug 26, 2021
@Belnut
resolve innovationacademy-kr#310 : TeamStatus 일부 상태 표기 및 미표기 상황 수정
3f3921e 
이제는 TeamStatus가 유효하지 않은 경우 (Timeout, end, Revoke) 페이지에 표기되지 않습니다.

수정 : jpql TeamStatus 조회를 'in' 으로 변경
수정 : Controller 에서 TeamRequest 요청 시 TeamStatus를 List로 받도록 수정
@Belnut Belnut linked a pull request Aug 26, 2021 that will close this issue
Resolve #310 : find 시 유효하지 않은 상태의 팀 표기 수정 #324
Merged
@Belnut Belnut mentioned this issue Aug 26, 2021
Closed
@Belnut Belnut closed this as completed in fedb009 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belnut Belnut

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Belnut