Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Referance Keys Implementation camelCase or snakeCase #48

Open
bekirbostanci opened this issue Jan 23, 2024 · 3 comments
Open

Error Referance Keys Implementation camelCase or snakeCase #48

bekirbostanci opened this issue Jan 23, 2024 · 3 comments

Comments

@bekirbostanci
Copy link

Actually when I looked vda5050 documentation it is really clear, All field names are in camelCase
Old version of the repo it was camelCase but then with updates why it changed to snakeCase?
image

Also at the error reference implementation at examples are camelCase
image

VDAErrorReference(reference_key="order_id", reference_value=order.order_id)

@miguelgarcia
Copy link
Member

miguelgarcia commented Jan 24, 2024

I +1 this one, references to VDA fields should be camelCased

@bekirbostanci
Copy link
Author

should I create pullrequest for this one ?

@miguelgarcia
Copy link
Member

Sure, go ahead 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants