Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt #26

Open
5 of 14 tasks
RSoulatIOHK opened this issue Sep 29, 2023 · 1 comment · Fixed by #32
Open
5 of 14 tasks

Technical debt #26

RSoulatIOHK opened this issue Sep 29, 2023 · 1 comment · Fixed by #32
Labels
story Story to be triaged Issue to be triaged by the team

Comments

@RSoulatIOHK
Copy link
Collaborator

RSoulatIOHK commented Sep 29, 2023

I'm using this issue to list things that needs to be fixed or changed but not urgently. Will move them to PI4 if they are not addressed before that:

Overall

  • Address the compiler warnings
  • Address the deprecated packages
  • Remove "DApp version" everywhere, we're not using it at all.
  • GDPR compliance => A user needs to be able to request their data, delete their data
  • Logging out, doesn't make you leave the page you're on

Auditor Report Upload

  • Need to be able to upload a pdf, json, etc. file in Auditor Report Upload => Also Check that the Hashes all match
  • On clickcing on "Add Script", I would prefer that either a) the new empty card gets on top or that the "+ Add Script" is also present at the end of the list so a user doesn't have to move all the way back up.
  • On clicking on "- Remove script", if some fields are filled, ask a confirmation to the user so they don't lose all their input for a simple misclick
  • Have a button "Send with wallet" and send the transaction with the metadata, after review
  • Change the "Send Report" to "Download metadata files"
  • Sanitize the input, especially for the parts where the use can input a URL
  • Auditor name should not be a Subject but just a string of fewer than 64 chars

User profile

  • Remove DApp information when you have an Auditor subscription
  • In DApp information, add "Subject" and make it unmutable (but maybe readable) if you have a Developer subscription (for the moment non existing) => This is a Product requirement to only allow 1 Dapp to be tested for a developer.
@amnambiar
Copy link
Collaborator

On clickcing on "Add Script", I would prefer that either a) the new empty card gets on top or that the "+ Add Script" is also present at the end of the list so a user doesn't have to move all the way back up.

Covered in PR #19

@EehMauro EehMauro mentioned this issue Oct 3, 2023
@RSoulatIOHK RSoulatIOHK reopened this Oct 11, 2023
@RSoulatIOHK RSoulatIOHK added story Story to be triaged Issue to be triaged by the team and removed enhancement labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Story to be triaged Issue to be triaged by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants