Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why is the Login button a div when it has children and a button without children? #581

Open
michaud opened this issue Feb 4, 2022 · 0 comments
Open

why is the Login button a div when it has children and a button without children? #581

michaud opened this issue Feb 4, 2022 · 0 comments

Comments

@michaud
Copy link

michaud commented Feb 4, 2022

solid-ui-react/src/components/logIn/index.tsx

Line 69 in 266e75b

return children ? (

After some cursory tests I don't get why the different elements with children (div) or without children (button).
It can just be a button. If it quacks ... :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaud